[Tables] updating docstring #19547
Merged
[Tables] updating docstring #19547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @seankane-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
annatisch
reviewed
Jun 28, 2021
| **kwargs: Any | ||
| ) -> None: | ||
| super(AsyncTablesBaseClient, self).__init__(endpoint, credential=credential, **kwargs) | ||
| super(AsyncTablesBaseClient, self).__init__(endpoint, credential=credential, **kwargs) # type: ignore |
Member
There was a problem hiding this comment.
Is this a problem that we are passing an async credential policy into the parent base_client constructor?
Contributor
Author
There was a problem hiding this comment.
Yes, this gets passed all the way down to AccountHostsMixin which expects a sync token credential.
| self.url, | ||
| table_name=table_name, | ||
| credential=self.credential, | ||
| credential=self.credential, # type: ignore |
Member
There was a problem hiding this comment.
Why do we have to suppress the type here?
Contributor
Author
There was a problem hiding this comment.
The AccountHostsMixin expects a sync token credential.
annatisch
approved these changes
Jun 28, 2021
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.