Cloud event should parse smaller ms precisions #19259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
rakshith91
commented
Jun 15, 2021
rakshith91
changed the title
lmazuel
reviewed
Jun 16, 2021
Member
lmazuel
left a comment
lmazuel
left a comment
There was a problem hiding this comment.
I'm confused a bit, I need to re-read RFC3339 or ISO8601
rakshith91
commented
Jun 22, 2021
swathipil
reviewed
Jun 22, 2021
swathipil
reviewed
Jun 22, 2021
Comment on lines
413
to
431
| def test_cloud_custom_dict_ms_precision_is_gt_six_z_not(): | ||
| time ="2021-02-18T20:18:10.539861122+00:00" | ||
| date_obj = _convert_to_isoformat(time) | ||
|
|
||
| assert date_obj.month == 2 | ||
| assert date_obj.day == 18 | ||
| assert date_obj.hour == 20 | ||
| assert date_obj.microsecond == 539861 | ||
|
|
||
| def test_cloud_custom_dict_ms_precision_is_lt_six_z_not(): | ||
| time ="2021-02-18T20:18:10.123+00:00" | ||
| date_obj = _convert_to_isoformat(time) | ||
|
|
||
| assert date_obj.month == 2 | ||
| assert date_obj.day == 18 | ||
| assert date_obj.hour == 20 | ||
| assert date_obj.microsecond == 123000 | ||
|
|
||
| def test_cloud_custom_dict_ms_precision_is_eq_six_z_not(): |
Member
There was a problem hiding this comment.
looks like times in these don't end with the Z?
rakshith91
commented
Jun 22, 2021
rakshith91
commented
Jun 22, 2021
rakshith91
commented
Jun 22, 2021
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Jun 24, 2021
…into get_testserver_working * 'main' of https://github.com/Azure/azure-sdk-for-python: (45 commits) ignore coretestserver readme (Azure#19436) Add Ubuntu 20 to local dns bypass template (Azure#19432) Sync eng/common directory with azure-sdk-tools for PR 1729 (Azure#19415) Async/BearerTokenCredentialPolicy consistently calls on_exception (Azure#19195) [EventHubs] Fix bug in sending stress test code and update default stress test settings (Azure#19429) [EventHubs] Get IoT Hub Name from Redirect Address in sample (Azure#19314) [textanalytics] regen on v3.1 (Azure#19193) Adapt EG to arm template (Azure#19262) [Key Vault] Extend pipeline test timeout (Azure#19404) Update platform matrix to ubuntu 20 (Azure#19296) [AppConfig] Add lock to SyncTokenPolicy (Azure#19395) Regenerate monitor code (Azure#19375) Increment version for keyvault releases (Azure#19402) Aggregation should be a list (Azure#19381) [azure-mgmt-monitor] skip test to unblock ci (Azure#19390) Cloud event should parse smaller ms precisions (Azure#19259) Update release date (Azure#19399) [Communication]: use x-ms-date for hmac (Azure#19396) [Key Vault] Performance tests for certificates, keys, and secrets (Azure#19002) Deprecate azure-monitor (Azure#19384) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19248
UPDATE:
Added more tests - this is an expected behavior