Skip to content

Handle metapackages that cannot be installed #16788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
praveenkuttappan merged 2 commits into from
Feb 18, 2021
Merged

Handle metapackages that cannot be installed #16788

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
914c8d9
Handle metapackages that cannot be installed
praveenkuttappan Feb 17, 2021
0dbd840
Set package properties and reduce python calls to get package properties
praveenkuttappan Feb 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion eng/scripts/Language-Settings.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,15 @@ function Get-python-PackageInfoFromRepo ($pkgPath, $serviceDirectory, $pkgName)
{
$setupLocation = $pkgPath.Replace('\','/')
pushd $RepoRoot
$setupProps = (python -c "import sys; import os; sys.path.append(os.path.join('scripts', 'devops_tasks')); from common_tasks import get_package_properties; obj=get_package_properties('$setupLocation'); print('{0},{1},{2}'.format(obj[0], obj[1], obj[2]));") -split ","
$setupProps = $null
try{
$setupProps = (python -c "import sys; import os; sys.path.append(os.path.join('scripts', 'devops_tasks')); from common_tasks import get_package_properties; obj=get_package_properties('$setupLocation'); print('{0},{1},{2}'.format(obj[0], obj[1], obj[2]));") -split ","
}
catch
{
# This is soft error and failure is expected for python metapackages
Write-Host "Failed to parse package properties for " $pkgName
}
popd
if (($setupProps -ne $null) -and ($setupProps[0] -eq $pkgName))
{
Expand All @@ -27,6 +35,7 @@ function Get-python-PackageInfoFromRepo ($pkgPath, $serviceDirectory, $pkgName)
$pkgProp.SdkType = "client"
}
$pkgProp.IsNewSdk = $setupProps[3]
$pkgProp.ArtifactName = $pkgName
return $pkgProp
}
}
Expand Down