From 4d04d5958a78a9beb9f18f7316f24bee760a5fdf Mon Sep 17 00:00:00 2001 From: "MIDDLEEAST\\v-moshaban" Date: Mon, 8 Feb 2021 11:08:50 +0200 Subject: [PATCH 1/4] added contains to DictMixin --- .../azure-ai-textanalytics/azure/ai/textanalytics/_models.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sdk/textanalytics/azure-ai-textanalytics/azure/ai/textanalytics/_models.py b/sdk/textanalytics/azure-ai-textanalytics/azure/ai/textanalytics/_models.py index c95585f76ed6..4db9f79f5639 100644 --- a/sdk/textanalytics/azure-ai-textanalytics/azure/ai/textanalytics/_models.py +++ b/sdk/textanalytics/azure-ai-textanalytics/azure/ai/textanalytics/_models.py @@ -43,6 +43,9 @@ def __ne__(self, other): """Compare objects by comparing all attributes.""" return not self.__eq__(other) + def __contains__(self, key): + return key in self.__dict__ + def __str__(self): return str({k: v for k, v in self.__dict__.items() if not k.startswith('_')}) From 46ff9e01cdd54d341f0d7cb28f42c7baad5e9a97 Mon Sep 17 00:00:00 2001 From: "MIDDLEEAST\\v-moshaban" Date: Wed, 10 Feb 2021 16:23:09 +0200 Subject: [PATCH 2/4] [unit test] added DictMixin unit tests --- .../tests/unit tests/models/test_DictMixin.py | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) create mode 100644 sdk/textanalytics/azure-ai-textanalytics/tests/unit tests/models/test_DictMixin.py diff --git a/sdk/textanalytics/azure-ai-textanalytics/tests/unit tests/models/test_DictMixin.py b/sdk/textanalytics/azure-ai-textanalytics/tests/unit tests/models/test_DictMixin.py new file mode 100644 index 000000000000..66d180967abf --- /dev/null +++ b/sdk/textanalytics/azure-ai-textanalytics/tests/unit tests/models/test_DictMixin.py @@ -0,0 +1,19 @@ +# coding=utf-8 +# ------------------------------------ +# Copyright (c) Microsoft Corporation. +# Licensed under the MIT License. +# ------------------------------------ + +import pytest + +from azure.ai.textanalytics._models import DictMixin + + +class TestDictMixin: + + def test_contains(self): + dict_mixin = DictMixin() + key = "name" + value = "steve" + dict_mixin.__setitem__(key, value) + assert dict_mixin.__contains__(key) \ No newline at end of file From 36b6183abadb30059ccc7fb8fbe270e113382243 Mon Sep 17 00:00:00 2001 From: "MIDDLEEAST\\v-moshaban" Date: Wed, 10 Feb 2021 16:32:14 +0200 Subject: [PATCH 3/4] [refactor] move test to same dir as all other tests --- .../models/test_DictMixin.py => test_dict_mixin.py} | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) rename sdk/textanalytics/azure-ai-textanalytics/tests/{unit tests/models/test_DictMixin.py => test_dict_mixin.py} (61%) diff --git a/sdk/textanalytics/azure-ai-textanalytics/tests/unit tests/models/test_DictMixin.py b/sdk/textanalytics/azure-ai-textanalytics/tests/test_dict_mixin.py similarity index 61% rename from sdk/textanalytics/azure-ai-textanalytics/tests/unit tests/models/test_DictMixin.py rename to sdk/textanalytics/azure-ai-textanalytics/tests/test_dict_mixin.py index 66d180967abf..0b869832a6d9 100644 --- a/sdk/textanalytics/azure-ai-textanalytics/tests/unit tests/models/test_DictMixin.py +++ b/sdk/textanalytics/azure-ai-textanalytics/tests/test_dict_mixin.py @@ -5,15 +5,14 @@ # ------------------------------------ import pytest - -from azure.ai.textanalytics._models import DictMixin +from azure.ai.textanalytics import _models class TestDictMixin: def test_contains(self): - dict_mixin = DictMixin() + model = _models.DictMixin() key = "name" value = "steve" - dict_mixin.__setitem__(key, value) - assert dict_mixin.__contains__(key) \ No newline at end of file + model.__setitem__(key, value) + assert model.__contains__(key) \ No newline at end of file From 4543536af5f99f5d580a6840a5c12a5c1bcf738d Mon Sep 17 00:00:00 2001 From: "MIDDLEEAST\\v-moshaban" Date: Wed, 10 Feb 2021 16:34:07 +0200 Subject: [PATCH 4/4] [refactor] ading new line at end of file (test_dict_mixin.py) --- .../azure-ai-textanalytics/tests/test_dict_mixin.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/textanalytics/azure-ai-textanalytics/tests/test_dict_mixin.py b/sdk/textanalytics/azure-ai-textanalytics/tests/test_dict_mixin.py index 0b869832a6d9..d308488a9e03 100644 --- a/sdk/textanalytics/azure-ai-textanalytics/tests/test_dict_mixin.py +++ b/sdk/textanalytics/azure-ai-textanalytics/tests/test_dict_mixin.py @@ -15,4 +15,4 @@ def test_contains(self): key = "name" value = "steve" model.__setitem__(key, value) - assert model.__contains__(key) \ No newline at end of file + assert model.__contains__(key)