[Bug][Datalake] Fixed Datalake Service Client context manager/session closure issue #16414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tasherif-msft
requested review from
amishra-dev,
annatisch,
kasobol-msft,
xiafu-msft and
zezha-msft
as code owners
ghost
added
the
kasobol-msft
approved these changes
Jan 29, 2021
xiafu-msft
reviewed
Jan 29, 2021
sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_data_lake_service_client.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #15358.
Currently using
close()or a context manager fails. This is becauseself._clientis called in datalake's base client.However datalake service client is using
blob_service_clientunder the hood and hence it does not have the attribute._clientof its own. This led to the inability of using context managers and gettingAttributeError.