From df723ccf71eefa57b07b973c9e300d16f5e49141 Mon Sep 17 00:00:00 2001 From: Sima Zhu Date: Mon, 25 Jan 2021 11:12:37 -0800 Subject: [PATCH 1/5] Run the link verification step even previous step failed. --- eng/common/pipelines/templates/steps/verify-links.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/eng/common/pipelines/templates/steps/verify-links.yml b/eng/common/pipelines/templates/steps/verify-links.yml index b23a266ccae5..46df511b6dd7 100644 --- a/eng/common/pipelines/templates/steps/verify-links.yml +++ b/eng/common/pipelines/templates/steps/verify-links.yml @@ -25,3 +25,4 @@ steps: -branchReplacementName ${{ parameters.BranchReplacementName }} -devOpsLogging: $true -checkLinkGuidance: ${{ parameters.CheckLinkGuidance }} + condition: succeededOrFailed() From 2a27f5d98e2579c11f1145c9986847839a8a22c4 Mon Sep 17 00:00:00 2001 From: Sima Zhu Date: Mon, 25 Jan 2021 11:18:27 -0800 Subject: [PATCH 2/5] Make the tab right --- eng/common/pipelines/templates/steps/verify-links.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eng/common/pipelines/templates/steps/verify-links.yml b/eng/common/pipelines/templates/steps/verify-links.yml index 46df511b6dd7..6350e9e7e7a6 100644 --- a/eng/common/pipelines/templates/steps/verify-links.yml +++ b/eng/common/pipelines/templates/steps/verify-links.yml @@ -25,4 +25,4 @@ steps: -branchReplacementName ${{ parameters.BranchReplacementName }} -devOpsLogging: $true -checkLinkGuidance: ${{ parameters.CheckLinkGuidance }} - condition: succeededOrFailed() + condition: succeededOrFailed() From 8c7486d0ef1a25f53fc119701f81cd476d002203 Mon Sep 17 00:00:00 2001 From: Sima Zhu Date: Mon, 25 Jan 2021 14:00:19 -0800 Subject: [PATCH 3/5] Address comments --- eng/common/pipelines/templates/steps/verify-links.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/eng/common/pipelines/templates/steps/verify-links.yml b/eng/common/pipelines/templates/steps/verify-links.yml index 6350e9e7e7a6..c17f87c417a3 100644 --- a/eng/common/pipelines/templates/steps/verify-links.yml +++ b/eng/common/pipelines/templates/steps/verify-links.yml @@ -8,6 +8,7 @@ parameters: Urls: '(Get-ChildItem -Path ./ -Recurse -Include *.md)' BranchReplaceRegex: "^(${env:SYSTEM_PULLREQUEST_SOURCEREPOSITORYURI}.*/(?:blob|tree)/)master(/.*)$" BranchReplacementName: "${env:SYSTEM_PULLREQUEST_SOURCECOMMITID}" + Condition: succeeded() steps: - task: PowerShell@2 @@ -25,4 +26,4 @@ steps: -branchReplacementName ${{ parameters.BranchReplacementName }} -devOpsLogging: $true -checkLinkGuidance: ${{ parameters.CheckLinkGuidance }} - condition: succeededOrFailed() + condition: ${{ parameters.Condition }} From cb21d0a74770ae96b4e61c708102f26340fed33e Mon Sep 17 00:00:00 2001 From: Sima Zhu Date: Tue, 26 Jan 2021 11:01:08 -0800 Subject: [PATCH 4/5] Run default condition if no RunOnFailure set. --- eng/common/pipelines/templates/steps/verify-links.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/eng/common/pipelines/templates/steps/verify-links.yml b/eng/common/pipelines/templates/steps/verify-links.yml index c17f87c417a3..46f84608f513 100644 --- a/eng/common/pipelines/templates/steps/verify-links.yml +++ b/eng/common/pipelines/templates/steps/verify-links.yml @@ -8,11 +8,12 @@ parameters: Urls: '(Get-ChildItem -Path ./ -Recurse -Include *.md)' BranchReplaceRegex: "^(${env:SYSTEM_PULLREQUEST_SOURCEREPOSITORYURI}.*/(?:blob|tree)/)master(/.*)$" BranchReplacementName: "${env:SYSTEM_PULLREQUEST_SOURCECOMMITID}" - Condition: succeeded() + RunOnFailure: $false steps: - task: PowerShell@2 displayName: Link verification check + condition: or(and(succeededOrFailed(), '${{ parameters.RunOnFailure }}'), and(succeeded(), eq('${{ parameters.RunOnFailure }}', false))) inputs: pwsh: true workingDirectory: '${{ parameters.WorkingDirectory }}/${{ parameters.Directory }}' @@ -26,4 +27,3 @@ steps: -branchReplacementName ${{ parameters.BranchReplacementName }} -devOpsLogging: $true -checkLinkGuidance: ${{ parameters.CheckLinkGuidance }} - condition: ${{ parameters.Condition }} From 273c35bda29d81064eaa89d4ba6291c3e04afa26 Mon Sep 17 00:00:00 2001 From: Sima Zhu Date: Tue, 26 Jan 2021 15:25:17 -0800 Subject: [PATCH 5/5] Changed back to simple condition --- eng/common/pipelines/templates/steps/verify-links.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/eng/common/pipelines/templates/steps/verify-links.yml b/eng/common/pipelines/templates/steps/verify-links.yml index 46f84608f513..1990ffe07dba 100644 --- a/eng/common/pipelines/templates/steps/verify-links.yml +++ b/eng/common/pipelines/templates/steps/verify-links.yml @@ -8,12 +8,12 @@ parameters: Urls: '(Get-ChildItem -Path ./ -Recurse -Include *.md)' BranchReplaceRegex: "^(${env:SYSTEM_PULLREQUEST_SOURCEREPOSITORYURI}.*/(?:blob|tree)/)master(/.*)$" BranchReplacementName: "${env:SYSTEM_PULLREQUEST_SOURCECOMMITID}" - RunOnFailure: $false + Condition: succeeded() # If you want to run on failure for the link checker, set it to `Condition: succeededOrFailed()`. steps: - task: PowerShell@2 displayName: Link verification check - condition: or(and(succeededOrFailed(), '${{ parameters.RunOnFailure }}'), and(succeeded(), eq('${{ parameters.RunOnFailure }}', false))) + condition: ${{ parameters.Condition }} inputs: pwsh: true workingDirectory: '${{ parameters.WorkingDirectory }}/${{ parameters.Directory }}'