diff --git a/sdk/communication/azure-communication-sms/tests/test_sms_client_e2e.py b/sdk/communication/azure-communication-sms/tests/test_sms_client_e2e.py index 577de40d28a2..922d2e3e9aa9 100644 --- a/sdk/communication/azure-communication-sms/tests/test_sms_client_e2e.py +++ b/sdk/communication/azure-communication-sms/tests/test_sms_client_e2e.py @@ -15,9 +15,6 @@ ResponseReplacerProcessor ) -SKIP_PHONE_NUMBER_TESTS = True -PHONE_NUMBER_TEST_SKIP_REASON= "Phone Number infra for live tests not ready yet" - class SMSClientTest(CommunicationTestCase): def __init__(self, method_name): super(SMSClientTest, self).__init__(method_name) @@ -28,7 +25,7 @@ def setUp(self): if self.is_playback(): self.phone_number = "+18000005555" else: - self.phone_number = os.getenv("PHONE_NUMBER") + self.phone_number = os.getenv("AZURE_COMMUNICATION_SERVICE_PHONE_NUMBER") self.recording_processors.extend([ BodyReplacerProcessor(keys=["to", "from", "messageId"]), @@ -37,7 +34,6 @@ def setUp(self): self.sms_client = SmsClient.from_connection_string(self.connection_str) @pytest.mark.live_test_only - @pytest.mark.skipif(SKIP_PHONE_NUMBER_TESTS, reason=PHONE_NUMBER_TEST_SKIP_REASON) def test_send_sms(self): # calling send() with sms values diff --git a/sdk/communication/azure-communication-sms/tests/test_sms_client_e2e_async.py b/sdk/communication/azure-communication-sms/tests/test_sms_client_e2e_async.py index ed3528594452..47f94bcada9b 100644 --- a/sdk/communication/azure-communication-sms/tests/test_sms_client_e2e_async.py +++ b/sdk/communication/azure-communication-sms/tests/test_sms_client_e2e_async.py @@ -15,9 +15,6 @@ BodyReplacerProcessor, ResponseReplacerProcessor ) -SKIP_PHONE_NUMBER_TESTS = True -PHONE_NUMBER_TEST_SKIP_REASON= "Phone Number infra for live tests not ready yet" - class SMSClientTestAsync(AsyncCommunicationTestCase): def __init__(self, method_name): super(SMSClientTestAsync, self).__init__(method_name) @@ -36,7 +33,6 @@ def setUp(self): @AsyncCommunicationTestCase.await_prepared_test @pytest.mark.live_test_only - @pytest.mark.skipif(SKIP_PHONE_NUMBER_TESTS, reason=PHONE_NUMBER_TEST_SKIP_REASON) async def test_send_sms_async(self): sms_client = SmsClient.from_connection_string(self.connection_str) diff --git a/sdk/communication/tests.yml b/sdk/communication/tests.yml index 571848a9c2b4..cc8a08643902 100644 --- a/sdk/communication/tests.yml +++ b/sdk/communication/tests.yml @@ -9,8 +9,8 @@ jobs: EnvVars: AZURE_TEST_RUN_LIVE: 'true' AZURE_TENANT_ID: $(aad-azure-sdk-test-tenant-id) - AZURE_SUBSCRIPTION_ID: $(azure-subscription-id) + AZURE_SUBSCRIPTION_ID: $(acs-subscription-id) AZURE_CLIENT_SECRET: $(aad-azure-sdk-test-client-secret) AZURE_CLIENT_ID: $(aad-azure-sdk-test-client-id) - AZURE_COMMUNICATION_SERVICE_CONNECTION_STRING: $(python-communication-connection-string) - AZURE_COMMUNICATION_SERVICE_PHONE_NUMBER: $(python-communication-phone-number) \ No newline at end of file + AZURE_COMMUNICATION_SERVICE_CONNECTION_STRING: $(communication-livetest-connection-string) + AZURE_COMMUNICATION_SERVICE_PHONE_NUMBER: $(communication-livetest-phone-number) \ No newline at end of file