Code Gen for QNA maker #15076
Closed
Code Gen for QNA maker #15076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakshith91
commented
Nov 6, 2020
|
|
||
| def download( | ||
| self, kb_id, environment, custom_headers=None, raw=False, **operation_config): | ||
| self, kb_id, environment, source=None, changed_since=None, custom_headers=None, raw=False, **operation_config): |
Contributor
Author
There was a problem hiding this comment.
this seems like a breaking change
Member
There was a problem hiding this comment.
it's borderline, custom_headers is a generated header from autorest (not the service), the likeliness that someone is using positional arguments all the way to custom_headers is very low, and we never increased a major version just for it (and never got any issue opened)
Contributor
Author
|
Closing in favor of #15086 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.