[ServiceBus] Improve resend test stability #12721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunhaoling
added
Service Bus
Client
yunhaoling
requested review from
KieranBrantnerMagee,
YijunXieMS and
annatisch
as code owners
Contributor
Author
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
KieranBrantnerMagee
approved these changes
Jul 24, 2020
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Jul 29, 2020
…into regenerate_keys * 'master' of https://github.com/Azure/azure-sdk-for-python: Add foundations for eng/common restructure (Azure#12725) Sync eng/common directory with azure-sdk-tools repository (Azure#12730) fix flaky test (Azure#12721) python link verification (Azure#12543) [ServiceBus] Remove legacy control client (Azure#12644) mirror update from MicrosoftDocs/azure-docs-sdk-python#709 (Azure#12691) [Service Bus] Rule supports parameters of sql expressions and properties of cor filter with multiple data types (Azure#12580)
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Jul 29, 2020
…into regenerate_certs * 'master' of https://github.com/Azure/azure-sdk-for-python: (45 commits) Prevent AttributeError during get_certificate_version (Azure#12747) re-apply updates after resetting master (Azure#12771) Sync eng/common directory with azure-sdk-tools repository (Azure#12745) Enable bandit for servicebus (Azure#12763) Skip pypy3 for service bus CI pipeline (Azure#12732) Update CODEOWNERS (Azure#12765) updated tox file (Azure#11087) Updating to match Microsoft recommended template (Azure#11045) [text analytics] update version in master (Azure#12749) Explicitly stringify message prints in samples per manual doc pass recommendation. (Azure#12709) Run only analyse dependency step for aggregate report (Azure#12728) VSCodeCredential supports Python 2.7 on Windows (Azure#12731) Enable bandit (Azure#12722) Move InteractiveCredential to a new module (Azure#12706) Add foundations for eng/common restructure (Azure#12725) Sync eng/common directory with azure-sdk-tools repository (Azure#12730) fix flaky test (Azure#12721) python link verification (Azure#12543) [ServiceBus] Remove legacy control client (Azure#12644) mirror update from MicrosoftDocs/azure-docs-sdk-python#709 (Azure#12691) ...
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Jul 29, 2020
…into add_back_pii * 'master' of https://github.com/Azure/azure-sdk-for-python: (40 commits) [text analytics] generate multiapi client, made v3.1-preview.1 default version (Azure#12720) Prevent AttributeError during get_certificate_version (Azure#12747) re-apply updates after resetting master (Azure#12771) Sync eng/common directory with azure-sdk-tools repository (Azure#12745) Enable bandit for servicebus (Azure#12763) Skip pypy3 for service bus CI pipeline (Azure#12732) Update CODEOWNERS (Azure#12765) updated tox file (Azure#11087) Updating to match Microsoft recommended template (Azure#11045) [text analytics] update version in master (Azure#12749) Explicitly stringify message prints in samples per manual doc pass recommendation. (Azure#12709) Run only analyse dependency step for aggregate report (Azure#12728) VSCodeCredential supports Python 2.7 on Windows (Azure#12731) Enable bandit (Azure#12722) Move InteractiveCredential to a new module (Azure#12706) Add foundations for eng/common restructure (Azure#12725) Sync eng/common directory with azure-sdk-tools repository (Azure#12730) fix flaky test (Azure#12721) python link verification (Azure#12543) [ServiceBus] Remove legacy control client (Azure#12644) ...
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Jul 30, 2020
…into opinion_mining * 'master' of https://github.com/Azure/azure-sdk-for-python: (69 commits) [formrecognizer] renames from consistency check (Azure#12752) [text analytics] add back PII endpoint (Azure#12673) [text analytics] generate multiapi client, made v3.1-preview.1 default version (Azure#12720) Prevent AttributeError during get_certificate_version (Azure#12747) re-apply updates after resetting master (Azure#12771) Sync eng/common directory with azure-sdk-tools repository (Azure#12745) Enable bandit for servicebus (Azure#12763) Skip pypy3 for service bus CI pipeline (Azure#12732) Update CODEOWNERS (Azure#12765) updated tox file (Azure#11087) Updating to match Microsoft recommended template (Azure#11045) [text analytics] update version in master (Azure#12749) Explicitly stringify message prints in samples per manual doc pass recommendation. (Azure#12709) Run only analyse dependency step for aggregate report (Azure#12728) VSCodeCredential supports Python 2.7 on Windows (Azure#12731) Enable bandit (Azure#12722) Move InteractiveCredential to a new module (Azure#12706) Add foundations for eng/common restructure (Azure#12725) Sync eng/common directory with azure-sdk-tools repository (Azure#12730) fix flaky test (Azure#12721) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous test implementation because the re-sending received message maybe received in the first loop,
leading assertion
assert message_received_cnt == 20failure.In this PR, improve the test by relying on the "label" to differentiate the messages which are re-send messages.