code refactoring #11638
code refactoring #11638
Conversation
heaths
left a comment
heaths
left a comment
There was a problem hiding this comment.
I'm signing off (with some questions/suggestions) on the API shape, not all the code changes. Please have someone from your language team review.
| 'name': {'key': 'name', 'type': 'str'}, | ||
| 'type': {'key': 'type', 'type': 'str'}, | ||
| 'key': {'key': 'key', 'type': 'bool'}, | ||
| 'is_hidden': {'key': 'isHidden', 'type': 'bool'}, |
There was a problem hiding this comment.
Why is this one prefaced with "is" while others are not? I'd be consistent for your language. Also, I'm not clear on what this _attribute_map is, since there's no isHidden on the model itself but, this is to be the reverse of retrievable that is on the model.
There was a problem hiding this comment.
All models exposed to users use is_hidden. Could you tell me which one you found w/o "is". It may be a bug...
There was a problem hiding this comment.
None of the properties below this had it. If these are internal mappings of some sort, not a big deal, but raises the question where is_hidden is coming from, given it's the negation of the JSON field retrievable.
|
/check-enforcer reset |
|
/check-enforcer evaluate |
No description provided.