Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

max_size_in_bytes value error incorrect f-string #37695

Closed
arheops opened this issue Oct 2, 2024 · 2 comments · Fixed by #37778
Closed

max_size_in_bytes value error incorrect f-string #37695

arheops opened this issue Oct 2, 2024 · 2 comments · Fixed by #37778
Assignees
@kashifkhan @swathipil @l0lawrence
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. Messaging Messaging crew needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Bus

Comments

@arheops
Copy link

arheops commented Oct 2, 2024

  • azure/service_bus/aio:
  • current:
  • MacOs:
  • python 3.10:

Describe the bug
In serviceBusSender create_message_batch at line 484 it has line like this

"acceptable max batch size is: {self._max_message_size_on_link} bytes."

missed f-string, should be like this

f"acceptable max batch size is: {self._max_message_size_on_link} bytes."f

To Reproduce
Steps to reproduce the behavior:
1
create batch with size of 10Mb

Expected behavior
Correct message about error

Screenshots
image

Additional context
Add any other context about the problem here.
@github-actions github-actions bot added Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Bus labels Oct 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

Thank you for your feedback. Tagging and routing to the team member best able to assist.

@kashifkhan
Copy link
Member

Thank you for the feedback @arheops . We will get a fix out quickly :)

@kashifkhan kashifkhan added the Messaging Messaging crew label Oct 2, 2024
@kashifkhan kashifkhan mentioned this issue Oct 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kashifkhan kashifkhan

@swathipil swathipil

@l0lawrence l0lawrence

Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. Messaging Messaging crew needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Bus
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[SB] - Fix F-String in Async kashifkhan/azure-sdk-for-python
4 participants
@kashifkhan @arheops @swathipil @l0lawrence