[SB] Missing Link Credit Subtraction #37427
Merged
+137
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check API changes are not detected in this pull request. |
l0lawrence
commented
Sep 17, 2024
sdk/servicebus/azure-servicebus/azure/servicebus/_pyamqp/receiver.py
Outdated
Show resolved
Hide resolved
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kashifkhan
reviewed
Sep 17, 2024
|
/azp run python - servicebus - perf |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - eventhub - tests |
|
Command 'python' is not supported by Azure Pipelines. Supported commands
See additional documentation. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
l0lawrence
commented
Sep 18, 2024
|
/azp run python - servicebus - perf |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - servicebus - perf |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - eventhub - perf |
|
Azure Pipelines successfully started running 1 pipeline(s). |
swathipil
reviewed
Sep 18, 2024
sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/aio/_receiver_async.py
Show resolved
Hide resolved
|
/azp run python - servicebus - perf |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - servicebus - perf |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kashifkhan
reviewed
Sep 19, 2024
sdk/servicebus/azure-servicebus/azure/servicebus/_servicebus_receiver.py
Show resolved
Hide resolved
kashifkhan
reviewed
Sep 19, 2024
swathipil
reviewed
Sep 19, 2024
kashifkhan
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to subtract current link credit on the wire instead of the batch size -- this can be used in the case that there are leftover credits on the wire we can still use to receive. Receive before sending flow credit to maximize this as well :)