Skip to content

Conversation

@seankane-msft
Copy link
Contributor

Fixing broken links found by the python - aggregate - reports pipeline

@yunhaoling
Copy link
Contributor

yunhaoling commented Mar 11, 2021

I remember https://azure.github.io/azure-sdk/python_introduction.html is still available on Monday or Tuesday.. otherwise the build pipeline for the release would fail due to links verification..

maybe we should check with the EngSys team to see why python_introduction.html is removed first?

@seankane-msft
Copy link
Contributor Author

/azp run python - aggregate-reports

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@ghost
Copy link

ghost commented Mar 11, 2021

Hello @seankane-msft!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

### Cross Service SDK improvements

The modern Key Vault client library also provides the ability to share in some of the cross-service improvements made to the Azure development experience, such as
The modern Key Vault client library also provides the ability to share in some of the cross-service improvements made to the Azure development experience, such as
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated these links yesterday but didn't realize that everyone had the same issue -- on line 26 I used https://azure.github.io/azure-sdk/general_introduction.html, but that can be replaced with https://azure.github.io/azure-sdk/python/guidelines/index.html. (This goes for keys and secrets as well)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding this change

Copy link
Member

@mccoyp mccoyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! :shipit:

@ghost ghost merged commit e6af37c into Azure:master Mar 11, 2021
@mitchdenny
Copy link
Contributor

Looks like this PR caused a CI failure, could you investigate @seankane-msft:
https://dev.azure.com/azure-sdk/public/_build/results?buildId=779018&view=results

@seankane-msft
Copy link
Contributor Author

Looks like this PR caused a CI failure, could you investigate @seankane-msft:
https://dev.azure.com/azure-sdk/public/_build/results?buildId=779018&view=results

@mitchdenny The failure is a test in Python 2.7, I don't believe it has to do with the changed links here.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants