-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Closed
Closed
Copy link
Labels
EngSysThis issue is impacting the engineering system.This issue is impacting the engineering system.
Milestone
Description
Extension of Issue: #16577
Summary
Many samples are long-running or run forever because of push mode. Currently, we choose to ignore these samples when testing in the live test pipeline. This is done by listing the samples in the IGNORED_SAMPLES of scripts/devops_tasks/test_run_samples.py. In order to test as many samples as possible, we should allow push-mode samples to run for a limited period of time then timeout.
Scope of work
- Check whether it is possible to include a
TIMED_SAMPLESsection that is similar to theIGNORED_SAMPLESsection of thetest_run_samples.py. - This section should allow adding push-mode samples from other services (like ServiceBus) as well
- Update
scripts/devops_tasks/test_run_samples.pyto run the samples included in theTIMED_SAMPLESsection for a given period of time. - Decide whether there should be a default timeout for each sample, or whether the user should be allowed to set the time. For example, two options below:
TIMED_SAMPLES = {
"azure-eventhub": [
# all samples timeout after x seconds
"<timed sample to be run>.py",
"<timed sample 2 to be run>.py"
]TIMED_SAMPLES = {
"azure-eventhub": [
# time in seconds
("<timed sample to be run>.py", 600),
("<timed sample 2 to be run>.py", 300)
]Success Criteria
- All push-mode samples run for the given period of time in the test pipeline
- All push-mode sample tests pass.
Metadata
Metadata
Assignees
Labels
EngSysThis issue is impacting the engineering system.This issue is impacting the engineering system.