update

Author: xiangyan99

sdk/search/azure-search-documents/azure/search/documents/_api_versions.py

@@ -7,8 +7,11 @@
     "2019-05-06-Preview",
 ]
 
-def check_api_version(api_version):
+def validate_api_version(api_version):
     # type: (str) -> None
+    """Raise error if api_version is invalid """
+    if not api_version:
+        return
     if api_version not in _SUPPORTED_API_VERSIONS:
         versions = '\n'.join(_SUPPORTED_API_VERSIONS)
         raise ValueError("Unsupported API version '{}'. Please select from:\n{}".format(api_version, versions))
@@ -17,6 +20,5 @@ def check_api_version(api_version):
 def get_api_version(kwargs, default):
     # type: (Dict[str, Any]) -> str
     api_version = kwargs.pop('api_version', None)
-    if api_version:
-        check_api_version(api_version)
+    validate_api_version(api_version)
     return api_version or default

sdk/search/azure-search-documents/azure/search/documents/_internal/_search_client.py

@@ -8,7 +8,7 @@
 import six
 
 from azure.core.tracing.decorator import distributed_trace
-from .._api_versions import check_api_version
+from .._api_versions import validate_api_version
 from ._generated import SearchIndexClient
 from ._generated.models import IndexBatch, IndexingResult
 from ._index_documents_batch import IndexDocumentsBatch
@@ -78,8 +78,7 @@ def __init__(self, endpoint, index_name, credential, **kwargs):
         # type: (str, str, AzureKeyCredential, **Any) -> None
 
         api_version = kwargs.pop('api_version', None)
-        if api_version:
-            check_api_version(api_version)
+        validate_api_version(api_version)
         self._endpoint = endpoint  # type: str
         self._index_name = index_name  # type: str
         self._credential = credential  # type: AzureKeyCredential

sdk/search/azure-search-documents/azure/search/documents/_internal/aio/_search_client_async.py

@@ -11,7 +11,7 @@
 from .._generated.models import IndexBatch, IndexingResult
 from .._index_documents_batch import IndexDocumentsBatch
 from .._queries import AutocompleteQuery, SearchQuery, SuggestQuery
-from ..._api_versions import check_api_version
+from ..._api_versions import validate_api_version
 from ..._headers_mixin import HeadersMixin
 from ..._version import SDK_MONIKER
 
@@ -48,8 +48,7 @@ def __init__(self, endpoint, index_name, credential, **kwargs):
         # type: (str, str, AzureKeyCredential, **Any) -> None
 
         api_version = kwargs.pop('api_version', None)
-        if api_version:
-            check_api_version(api_version)
+        validate_api_version(api_version)
         self._endpoint = endpoint  # type: str
         self._index_name = index_name  # type: str
         self._credential = credential  # type: AzureKeyCredential

sdk/search/azure-search-documents/azure/search/documents/indexes/_internal/_search_index_client.py

@@ -9,7 +9,7 @@
 from azure.core.tracing.decorator import distributed_trace
 from azure.core.paging import ItemPaged
 
-from ..._api_versions import check_api_version
+from ..._api_versions import validate_api_version
 from ._generated import SearchServiceClient as _SearchServiceClient
 from ._utils import (
     unpack_search_index,
@@ -46,8 +46,7 @@ def __init__(self, endpoint, credential, **kwargs):
         # type: (str, AzureKeyCredential, **Any) -> None
 
         api_version = kwargs.pop('api_version', None)
-        if api_version:
-            check_api_version(api_version)
+        validate_api_version(api_version)
         self._endpoint = normalize_endpoint(endpoint)  # type: str
         self._credential = credential  # type: AzureKeyCredential
         self._client = _SearchServiceClient(

sdk/search/azure-search-documents/azure/search/documents/indexes/_internal/_search_indexer_client.py

@@ -16,7 +16,7 @@
     pack_search_indexer_data_source,
     unpack_search_indexer_data_source,
 )
-from ..._api_versions import check_api_version
+from ..._api_versions import validate_api_version
 from ..._headers_mixin import HeadersMixin
 from ..._version import SDK_MONIKER
 
@@ -44,8 +44,7 @@ def __init__(self, endpoint, credential, **kwargs):
         # type: (str, AzureKeyCredential, **Any) -> None
 
         api_version = kwargs.pop('api_version', None)
-        if api_version:
-            check_api_version(api_version)
+        validate_api_version(api_version)
         self._endpoint = normalize_endpoint(endpoint)  # type: str
         self._credential = credential  # type: AzureKeyCredential
         self._client = _SearchServiceClient(

sdk/search/azure-search-documents/azure/search/documents/indexes/_internal/aio/_search_index_client.py

@@ -19,7 +19,7 @@
     get_access_conditions,
     normalize_endpoint,
 )
-from ...._api_versions import check_api_version
+from ...._api_versions import validate_api_version
 from ...._headers_mixin import HeadersMixin
 from ...._version import SDK_MONIKER
 
@@ -48,8 +48,7 @@ def __init__(self, endpoint, credential, **kwargs):
         # type: (str, AzureKeyCredential, **Any) -> None
 
         api_version = kwargs.pop('api_version', None)
-        if api_version:
-            check_api_version(api_version)
+        validate_api_version(api_version)
         self._endpoint = normalize_endpoint(endpoint)  # type: str
         self._credential = credential  # type: AzureKeyCredential
         self._client = _SearchServiceClient(

sdk/search/azure-search-documents/azure/search/documents/indexes/_internal/aio/_search_indexer_client.py

@@ -16,7 +16,7 @@
     pack_search_indexer_data_source,
     unpack_search_indexer_data_source,
 )
-from ...._api_versions import check_api_version
+from ...._api_versions import validate_api_version
 from ...._headers_mixin import HeadersMixin
 from ...._version import SDK_MONIKER
 
@@ -44,8 +44,7 @@ def __init__(self, endpoint, credential, **kwargs):
         # type: (str, AzureKeyCredential, **Any) -> None
 
         api_version = kwargs.pop('api_version', None)
-        if api_version:
-            check_api_version(api_version)
+        validate_api_version(api_version)
         self._endpoint = normalize_endpoint(endpoint)  # type: str
         self._credential = credential  # type: AzureKeyCredential
         self._client = _SearchServiceClient(