Skip to content

Commit 0e586b0

Browse files
committed
fix pylint and update changelog
1 parent 807b69b commit 0e586b0

File tree

3 files changed

+10
-5
lines changed

3 files changed

+10
-5
lines changed

sdk/storage/azure-storage-blob-changefeed/CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
## 12.0.0b2 (2020-9-9)
2+
**Breaking changes**
3+
- Change the `continuation_token` from a dict to a str.
4+
- `start_time`/`end_time` and `continuation_token` are mutually exclusive now.
5+
16
## 12.0.0b1 (2020-07-07)
27
- Initial Release. Please see the README for information on the new design.
38
- Support for ChangeFeedClient: get change feed events by page, get all change feed events, get events in a time range

sdk/storage/azure-storage-blob-changefeed/azure/storage/blob/changefeed/_models.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,17 +58,17 @@ def __init__(
5858
extract_data=self._extract_data_cb,
5959
continuation_token=continuation_token or ""
6060
)
61-
continuation_token = json.loads(continuation_token) if continuation_token else None
61+
dict_continuation_token = json.loads(continuation_token) if continuation_token else None # type: dict
6262

63-
if continuation_token and (container_client.primary_hostname != continuation_token["UrlHost"]):
63+
if dict_continuation_token and (container_client.primary_hostname != dict_continuation_token["UrlHost"]): # pylint: disable=unsubscriptable-object
6464
raise ValueError("The token is not for the current storage account.")
65-
if continuation_token and (continuation_token["CursorVersion"] != 1):
65+
if dict_continuation_token and (dict_continuation_token["CursorVersion"] != 1): # pylint: disable=unsubscriptable-object
6666
raise ValueError("The CursorVersion is not supported by the current SDK.")
6767
self.results_per_page = results_per_page or 5000
6868
self.current_page = None
6969
self._change_feed = ChangeFeed(container_client, self.results_per_page, start_time=start_time,
7070
end_time=end_time,
71-
cf_cursor=continuation_token)
71+
cf_cursor=dict_continuation_token)
7272

7373
def _get_next_cf(self, continuation_token): # pylint:disable=unused-argument
7474
try:

sdk/storage/azure-storage-blob-changefeed/azure/storage/blob/changefeed/_version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,4 @@
44
# license information.
55
# --------------------------------------------------------------------------
66

7-
VERSION = "12.0.0b1"
7+
VERSION = "12.0.0b2"

0 commit comments

Comments
 (0)