Skip to content

Conversation

@goergenj
Copy link

…for Voice live

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

Copilot AI review requested due to automatic review settings October 29, 2025 00:20
@goergenj goergenj requested a review from a team as a code owner October 29, 2025 00:20
@github-actions github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Voice Live labels Oct 29, 2025
@github-actions
Copy link

Thank you for your contribution @goergenj! We will review the pull request and get back to you soon.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds two standalone, consolidated quickstart samples for the Azure.AI.VoiceLive SDK, along with updating configuration templates in the main sample project. The quickstarts demonstrate voice assistant capabilities through self-contained examples that can be distributed independently.

  • Adds consolidated quickstart samples for model-based and agent-based voice assistants
  • Updates configuration templates with new Azure endpoint patterns and voice models
  • Adds root-level project files (appear to be unintentional)

Reviewed Changes

Copilot reviewed 19 out of 20 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
model_quickstart/Program.cs Self-contained voice assistant sample using VoiceLive models directly
agent_quickstart/Program.cs Self-contained voice assistant sample connecting to Azure AI Foundry agents
model_quickstart/README.md Documentation for the model-based quickstart sample
agent_quickstart/README.md Documentation for the agent-based quickstart sample
model_quickstart/appsettings.template.json Configuration template for model quickstart
agent_quickstart/appsettings.template.json Configuration template for agent quickstart (missing comma)
model_quickstart/*.csproj, Directory.Build.props, NuGet.Config Build configuration for standalone model quickstart
agent_quickstart/*.csproj, Directory.Build.props, NuGet.Config Build configuration for standalone agent quickstart
BasicVoiceAssistant/appsettings.template.json Updated with new Azure endpoints and voice models
BasicVoiceAssistant/appsettings.json File deleted (now gitignored)
azure-sdk-for-net.csproj, Program.cs Unintentional root-level project files
.gitignore Added global appsettings.json ignore

Copy link
Member

@jsquire jsquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@goergenj:

Your account lacks the public GitHub organization memberships and permissions required of an internal contributor. Please review the Azure SDK onboarding documentation and use the associated Teams channel for support.

You can verify the state of your account by running the Validate-AzsdkCodeOwner script from the Azure SDK tools repository.

Please also be sure to add yourself to CODEOWNERS for this library, if you will be maintaining it going forward.

.gitignore Outdated
# Common toolchain intermediate files
temp

# Appsettings files
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert. You should not be making changes outside of your /sdk directory.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be reverted.

Program.cs Outdated
@@ -0,0 +1,2 @@
// See https://aka.ms/new-console-template for more information
Console.WriteLine("Hello, World!");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be reverted.

@@ -0,0 +1,11 @@
<Project Sdk="Microsoft.NET.Sdk">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be reverted.

<packageSources>
<clear />
<!-- Use only the public NuGet.org feed for standalone distribution -->
<add key="nuget.org" value="https://api.nuget.org/v3/index.json" protocolVersion="3" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be removed. Only the approved root NuGet sources may be used in this repository.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

<packageSources>
<clear />
<!-- Use only the public NuGet.org feed for standalone distribution -->
<add key="nuget.org" value="https://api.nuget.org/v3/index.json" protocolVersion="3" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be removed. Only the approved root source may be used in this repository.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

</ItemGroup>

<!-- Use project reference (works in the repository context) -->
<ItemGroup>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will fail to build outside of the repository.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated this based on the version in the parent folder and tested the new version. Please re-check.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parent folder is incorrect and will not build outside of this repository. It also snuck in an unapproved dependency via use of override which will be remediated.

Stand-alone samples must be buildable inside the repository and stand-alone, as the docs process will export them as stand-alone samples.

</PropertyGroup>

<ItemGroup>
<PackageReference Include="Azure.Identity" Version="1.12.1"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be more robust such that the repository central versions get used when building in the repo and you have fallback versions outside the repository.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated based on the version in parent folder present before now without the Version.


<ItemGroup>
<PackageReference Include="Azure.Identity" Version="1.12.1"/>
<PackageReference Include="NAudio" Version="2.2.1"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not an approved dependency and may not be used in the repository. For consideration as an approved test/sample reference, please submit an email request to myself, Krzysztof Cwalina, Christopher Scott, and Scott Addie.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated based on the version in parent folder present before.

</PropertyGroup>

<ItemGroup>
<PackageReference Include="Azure.Identity" Version="1.12.1"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments from the other .csproj. They apply here as well.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated this based on the version in the parent folder and tested the new version. Please re-check.

Copy link
Member

@m-redding m-redding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert the root level changes

Copy link
Member

@m-redding m-redding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

root is resolved thanks!

@m-redding m-redding dismissed their stale review October 29, 2025 19:15

resolved

</ItemGroup>

<!-- Use project reference (works in the repository context) -->
<ItemGroup>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parent folder is incorrect and will not build outside of this repository. It also snuck in an unapproved dependency via use of override which will be remediated.

Stand-alone samples must be buildable inside the repository and stand-alone, as the docs process will export them as stand-alone samples.

@jsquire
Copy link
Member

jsquire commented Oct 30, 2025

Related: #53586

@goergenj
Copy link
Author

@jsquire I removed the NAudio package from the csproj and put it as a pre-requisite requirement in then README until this topic can be solved.

@goergenj goergenj requested a review from Copilot October 31, 2025 23:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 7 comments.

@goergenj goergenj requested a review from jsquire October 31, 2025 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Voice Live

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants