-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Added consolidated quickstart versions for model and agent of BasicVoiceAssistant sample … #53547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thank you for your contribution @goergenj! We will review the pull request and get back to you soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds two standalone, consolidated quickstart samples for the Azure.AI.VoiceLive SDK, along with updating configuration templates in the main sample project. The quickstarts demonstrate voice assistant capabilities through self-contained examples that can be distributed independently.
- Adds consolidated quickstart samples for model-based and agent-based voice assistants
- Updates configuration templates with new Azure endpoint patterns and voice models
- Adds root-level project files (appear to be unintentional)
Reviewed Changes
Copilot reviewed 19 out of 20 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| model_quickstart/Program.cs | Self-contained voice assistant sample using VoiceLive models directly |
| agent_quickstart/Program.cs | Self-contained voice assistant sample connecting to Azure AI Foundry agents |
| model_quickstart/README.md | Documentation for the model-based quickstart sample |
| agent_quickstart/README.md | Documentation for the agent-based quickstart sample |
| model_quickstart/appsettings.template.json | Configuration template for model quickstart |
| agent_quickstart/appsettings.template.json | Configuration template for agent quickstart (missing comma) |
| model_quickstart/*.csproj, Directory.Build.props, NuGet.Config | Build configuration for standalone model quickstart |
| agent_quickstart/*.csproj, Directory.Build.props, NuGet.Config | Build configuration for standalone agent quickstart |
| BasicVoiceAssistant/appsettings.template.json | Updated with new Azure endpoints and voice models |
| BasicVoiceAssistant/appsettings.json | File deleted (now gitignored) |
| azure-sdk-for-net.csproj, Program.cs | Unintentional root-level project files |
| .gitignore | Added global appsettings.json ignore |
...ples/BasicVoiceAssistant/consolidated_quickstarts/agent_quickstart/appsettings.template.json
Outdated
Show resolved
Hide resolved
...I.VoiceLive/samples/BasicVoiceAssistant/consolidated_quickstarts/model_quickstart/Program.cs
Outdated
Show resolved
Hide resolved
...I.VoiceLive/samples/BasicVoiceAssistant/consolidated_quickstarts/agent_quickstart/Program.cs
Outdated
Show resolved
Hide resolved
jsquire
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your account lacks the public GitHub organization memberships and permissions required of an internal contributor. Please review the Azure SDK onboarding documentation and use the associated Teams channel for support.
- Azure SDK onboarding (Microsoft internal)
- Azure SDK onboarding assistance (Microsoft internal)
You can verify the state of your account by running the Validate-AzsdkCodeOwner script from the Azure SDK tools repository.
Please also be sure to add yourself to CODEOWNERS for this library, if you will be maintaining it going forward.
.gitignore
Outdated
| # Common toolchain intermediate files | ||
| temp | ||
|
|
||
| # Appsettings files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert. You should not be making changes outside of your /sdk directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be reverted.
Program.cs
Outdated
| @@ -0,0 +1,2 @@ | |||
| // See https://aka.ms/new-console-template for more information | |||
| Console.WriteLine("Hello, World!"); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be reverted.
azure-sdk-for-net.csproj
Outdated
| @@ -0,0 +1,11 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be reverted.
| <packageSources> | ||
| <clear /> | ||
| <!-- Use only the public NuGet.org feed for standalone distribution --> | ||
| <add key="nuget.org" value="https://api.nuget.org/v3/index.json" protocolVersion="3" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be removed. Only the approved root NuGet sources may be used in this repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
| <packageSources> | ||
| <clear /> | ||
| <!-- Use only the public NuGet.org feed for standalone distribution --> | ||
| <add key="nuget.org" value="https://api.nuget.org/v3/index.json" protocolVersion="3" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be removed. Only the approved root source may be used in this repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
| </ItemGroup> | ||
|
|
||
| <!-- Use project reference (works in the repository context) --> | ||
| <ItemGroup> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will fail to build outside of the repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated this based on the version in the parent folder and tested the new version. Please re-check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The parent folder is incorrect and will not build outside of this repository. It also snuck in an unapproved dependency via use of override which will be remediated.
Stand-alone samples must be buildable inside the repository and stand-alone, as the docs process will export them as stand-alone samples.
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Azure.Identity" Version="1.12.1"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be more robust such that the repository central versions get used when building in the repo and you have fallback versions outside the repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated based on the version in parent folder present before now without the Version.
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Azure.Identity" Version="1.12.1"/> | ||
| <PackageReference Include="NAudio" Version="2.2.1"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not an approved dependency and may not be used in the repository. For consideration as an approved test/sample reference, please submit an email request to myself, Krzysztof Cwalina, Christopher Scott, and Scott Addie.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated based on the version in parent folder present before.
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Azure.Identity" Version="1.12.1"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see comments from the other .csproj. They apply here as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated this based on the version in the parent folder and tested the new version. Please re-check.
sdk/ai/Azure.AI.VoiceLive/samples/BasicVoiceAssistant/.gitignore
Outdated
Show resolved
Hide resolved
m-redding
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please revert the root level changes
…ated_quickstarts/agent_quickstart/appsettings.template.json Co-authored-by: Copilot <[email protected]>
…ated_quickstarts/model_quickstart/Program.cs Co-authored-by: Copilot <[email protected]>
…ated_quickstarts/agent_quickstart/Program.cs Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
m-redding
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
root is resolved thanks!
...VoiceLive/samples/BasicVoiceAssistant/consolidated_quickstarts/agent_quickstart/NuGet.Config
Outdated
Show resolved
Hide resolved
| </ItemGroup> | ||
|
|
||
| <!-- Use project reference (works in the repository context) --> | ||
| <ItemGroup> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The parent folder is incorrect and will not build outside of this repository. It also snuck in an unapproved dependency via use of override which will be remediated.
Stand-alone samples must be buildable inside the repository and stand-alone, as the docs process will export them as stand-alone samples.
|
Related: #53586 |
… in the samples folder for clear structure
|
@jsquire I removed the NAudio package from the csproj and put it as a pre-requisite requirement in then README until this topic can be solved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 14 out of 14 changed files in this pull request and generated 7 comments.
sdk/ai/Azure.AI.VoiceLive/samples/BasicVoiceAssistantQuickstart/README.md
Outdated
Show resolved
Hide resolved
sdk/ai/Azure.AI.VoiceLive/samples/AgentVoiceAssistantQuickstart/README.md
Outdated
Show resolved
Hide resolved
sdk/ai/Azure.AI.VoiceLive/samples/BasicVoiceAssistantQuickstart/NuGet.Config
Outdated
Show resolved
Hide resolved
sdk/ai/Azure.AI.VoiceLive/samples/AgentVoiceAssistantQuickstart/NuGet.Config
Outdated
Show resolved
Hide resolved
sdk/ai/Azure.AI.VoiceLive/samples/BasicVoiceAssistantQuickstart/README.md
Show resolved
Hide resolved
sdk/ai/Azure.AI.VoiceLive/samples/AgentVoiceAssistantQuickstart/README.md
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
…t/NuGet.Config Co-authored-by: Copilot <[email protected]>
…t/README.md Co-authored-by: Copilot <[email protected]>
…t/README.md Co-authored-by: Copilot <[email protected]>
…t/NuGet.Config Co-authored-by: Copilot <[email protected]>
…for Voice live
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.