Skip to content

Fix: Don't change working directory when invoking tsp-client #53156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 10, 2025
Merged

Fix: Don't change working directory when invoking tsp-client #53156

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b858596
Initial plan
Copilot Oct 10, 2025
940ca47
Fix: Don't change working directory when invoking tsp-client
Copilot Oct 10, 2025
01ad6c9
Use full path to tsp-client binary instead of npm exec
Copilot Oct 10, 2025
f5243ee
Use npm exec --prefix to invoke tsp-client
Copilot Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 12 additions & 18 deletions eng/scripts/Invoke-GenerateAndBuildV2.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,26 +132,20 @@ if ($relatedTypeSpecProjectFolder) {

# Install tsp-client dependencies from eng/common/tsp-client
$tspClientDir = Resolve-Path (Join-Path $PSScriptRoot "../common/tsp-client")
Push-Location $tspClientDir
try {
Write-Host "Installing tsp-client dependencies from $tspClientDir"
npm ci
if ($LASTEXITCODE) {
Write-Error "Failed to install tsp-client dependencies"
exit $LASTEXITCODE
}

# Use tsp-client from pinned version by running from tsp-client directory
$tspclientCommand = "npm exec --no -- tsp-client init --update-if-exists --tsp-config $tspConfigFile --repo $repo --commit $commitid"
if ($swaggerDir) {
$tspclientCommand += " --local-spec-repo $typespecFolder"
}
Write-Host $tspclientCommand
Invoke-Expression $tspclientCommand
Write-Host "Installing tsp-client dependencies from $tspClientDir"
npm ci --prefix $tspClientDir
if ($LASTEXITCODE) {
Write-Error "Failed to install tsp-client dependencies"
exit $LASTEXITCODE
}
finally {
Pop-Location

# Use tsp-client from pinned version by passing --prefix to use tsp-client from that directory
$tspclientCommand = "npm exec --prefix $tspClientDir --no -- tsp-client init --update-if-exists --tsp-config $tspConfigFile --repo $repo --commit $commitid"
if ($swaggerDir) {
$tspclientCommand += " --local-spec-repo $typespecFolder"
}
Write-Host $tspclientCommand
Invoke-Expression $tspclientCommand

if ($LASTEXITCODE) {
# If Process script call fails, then return with failure to CI and don't need to call GeneratePackage
Expand Down
Loading