Skip to content

Conversation

@nking-1
Copy link

@nking-1 nking-1 commented Feb 14, 2019

Description

This PR is for a new WebSites SDK generated from a new swagger spec: Azure/azure-rest-api-specs#5111

There is one potentially breaking change resulting from the latest swagger changes. A property called AdminSiteName was removed from the AppServicePlan model. This property was never intended to be exposed to customers and has been removed to prevent confusion.


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

<Version>2.0.1</Version>
<Version>2.1.0</Version>
<PackageTags>Microsoft Azure website management;website management;</PackageTags>
<PackageReleaseNotes>Taking dependency on 10.0.3 version of Newtonsoft nuget package.</PackageReleaseNotes>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update PackageReleaseNotes


[assembly: AssemblyVersion("2.0.0")]
[assembly: AssemblyFileVersion("2.0.1")]
[assembly: AssemblyVersion("2.1.0")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AssemblyVersion must remain unchanged, AssemblyFileVersion must be updated

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM will merge once CIs pass

@dsgouda dsgouda merged commit 878426a into Azure:master Feb 15, 2019
mentat9 pushed a commit to mentat9/azure-sdk-for-net that referenced this pull request Jun 10, 2019
* Regenerated WebSites SDK for ANT80 REST API spec

* Update assembly version for WebSites SDK

* Update package release notes, fix assembly version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants