Generating SDK for websites #4688

panchagnula · 2018-08-22T02:59:00Z

Description

New .NET SDK generated for Websites extension.
Swagger PR Azure/azure-rest-api-specs#3692

This checklist is used to make sure that common guidelines for a pull request are followed.

Please add REST spec PR link to the SDK PR
I have read the contribution guidelines.
The pull request does not introduce breaking changes.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

SDK Generation Guidelines

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

dsgouda · 2018-08-22T20:20:12Z

NuGet.Config

Please undo these changes

dsgouda · 2018-08-22T20:21:10Z

src/SDKs/WebSites/Management.Websites/Generated/SdkInfo_WebSiteManagementClient.cs

Please pull latest changes from remote and run msbuild build.proj and regenerate the code

dsgouda · 2018-08-22T20:22:38Z

src/SDKs/WebSites/Management.Websites/Generated/AppServiceCertificateOrdersOperations.cs

Looks like the API version is being bumped. Please bump the major version here
Also update the PackageReleaseNotes and AssemblyInfo.cs accordingly

dsgouda · 2018-08-22T20:24:53Z

@panchagnula also fix the CI build failures

…abling a test

panchagnula · 2018-08-23T00:40:52Z

@dsgouda - feedback addressed

dsgouda

It looks like the REST API version is stable, is there a reason you wish to publish preview Nuget packages.
We generally recommend publishing stable Nuget packages for stable REST API versions

dsgouda · 2018-08-23T16:14:35Z

src/SDKs/WebSites/Management.Websites/Microsoft.Azure.Management.Websites.csproj

@@ -19,5 +19,8 @@

 	<!-- Please do not move/edit code below this line -->
 	<Import Condition=" Exists('$([MSBuild]::GetPathOfFileAbove(AzSdk.RP.props))') " Project="$([MSBuild]::GetPathOfFileAbove('AzSdk.RP.props'))" />
+	<ItemGroup>
+	  <PackageReference Update="Microsoft.Rest.ClientRuntime.Azure" Version="3.3.15" />


Please remove this

@dsgouda had to add this due to a bug in .NET SDK with provisioning state polling code . see the email below for details
@shahabhijeet as FYI as well.

Can you update to the latest version of Microsoft.Rest.ClientRuntime.Azure and that should do the fix for that particular error.

Abhijeet

From: Nicholas King
Sent: Wednesday, August 22, 2018 3:43 PM
To: Abhijeet Shah
Hi Abhijeet,

Sisira and I are working on updating the Web Apps SDK right now, and we’ve gotten stuck recording some of our tests. I dug through the code and noticed you’ve been working on the provisioning state polling code. Hopefully you’ll be able to help us out.

We have a test that creates an AppServicePlan (a.k.a. ServerFarm internally), then updates the AppServicePlan. Both creating and updating are done with PUT requests to the same URL. When creating the AppServicePlan the response contains provisioningState: Succeeded, but when updating it, the response contains provisioningState: null. The internal SDK Client is throwing an exception “Provisioning state is missing from long running operation.”

I attached a recording of the failing test. My main question for now is, is there an issue with how our API currently works, or is the problem fixable inside the .NET SDK?

Thanks
Nick

Thanks for confirming. We need to take a look at this and decide if we can allow a one off here or if we are ready to move our ClientRuntime dependency to the latest version for all sdks.

@panchagnula Please revert this change, we are planning to bump the version dependency for all SDKs across the repo, will merge this PR once that is done.

dsgouda · 2018-08-23T16:15:24Z

src/SDKs/WebSites/Management.Websites/Properties/AssemblyInfo.cs

@@ -9,7 +9,7 @@
 [assembly: AssemblyDescription("Provides management functionality for Microsoft Azure Web Sites.")]

 [assembly: AssemblyVersion("1.0.0")]
-[assembly: AssemblyFileVersion("1.8.0")]
+[assembly: AssemblyFileVersion("1.9.0")]


Since you are bumping the major version, both AssemblyFileVersion and AssemblyVersion must be bumped to 2.0.0.0

panchagnula · 2018-08-23T19:19:15Z

@dsgouda regarding "is there a reason you wish to publish preview Nuget packages.
We generally recommend publishing stable Nuget packages for stable REST API versions" - I am not sure about the history for this SDK being in preview - I just updated the version, following up some folks on my team who might have context on our SDK version being in preview. CC:// @naveedaz

dsgouda · 2018-08-23T20:01:00Z

Will wait from an approval from @naveedaz regarding SDK Nuget versioning

naveedaz · 2018-08-23T20:19:21Z

Updating to non preview version should be fine.

panchagnula · 2018-08-28T16:10:32Z

@dsgouda , the related rest-api-specs change got merged, please let me know if this is ready to be published as well or if you need anything else from our end. Thank you.

dsgouda · 2018-08-28T16:25:25Z

@panchagnula Will address/merge this today

dsgouda · 2018-08-28T21:03:28Z

Waiting on clientruntime dependencies to bumped across the repo

dsgouda suggested changes Aug 22, 2018

View reviewed changes

panchagnula added 4 commits August 22, 2018 16:26

Generating SDK for websites

702eb4e

Adding the generated files

7c83895

Undo NuGet.config changes & updating version

f8c1c3a

Updating to use the latest Microsoft.Rest.ClientRuntime.Azure & re-en…

cbeaded

…abling a test

panchagnula force-pushed the psSdkJson6 branch from f04bf28 to cbeaded Compare August 22, 2018 23:28

dsgouda reviewed Aug 23, 2018

View reviewed changes

dsgouda added the Changes Requested label Aug 23, 2018

Version update

725515f

Updating with the swagger update for deletedSites

693a8d2

dsgouda added Do Not Merge and removed Changes Requested labels Aug 28, 2018

dsgouda approved these changes Aug 28, 2018

View reviewed changes

dsgouda added the Changes Requested label Aug 28, 2018

shahabhijeet approved these changes Aug 29, 2018

View reviewed changes

shahabhijeet merged commit 32a66cd into Azure:psSdkJson6 Aug 29, 2018

panchagnula mentioned this pull request Sep 6, 2018

Websites: Updating websites module to use the latest released .NET SDK version of websites Azure/azure-powershell#7127

Merged

8 tasks

Generating SDK for websites #4688

Generating SDK for websites #4688

Uh oh!

Conversation

panchagnula commented Aug 22, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dsgouda commented Aug 22, 2018

Uh oh!

panchagnula commented Aug 23, 2018

Uh oh!

dsgouda left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

@dsgouda had to add this due to a bug in .NET SDK with provisioning state polling code . see the email below for details @shahabhijeet as FYI as well.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

panchagnula commented Aug 23, 2018

Uh oh!

dsgouda commented Aug 23, 2018

Uh oh!

naveedaz commented Aug 23, 2018

Uh oh!

panchagnula commented Aug 28, 2018

Uh oh!

dsgouda commented Aug 28, 2018

Uh oh!

dsgouda commented Aug 28, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

panchagnula commented Aug 22, 2018 •

edited

Loading

@dsgouda had to add this due to a bug in .NET SDK with provisioning state polling code . see the email below for details
@shahabhijeet as FYI as well.