diff --git a/sdk/keyvault/Azure.Security.KeyVault.Secrets/src/SecretClientBuilderExtensions.cs b/sdk/keyvault/Azure.Security.KeyVault.Secrets/src/SecretClientBuilderExtensions.cs index eb33d724c9be..f8c196c49b23 100644 --- a/sdk/keyvault/Azure.Security.KeyVault.Secrets/src/SecretClientBuilderExtensions.cs +++ b/sdk/keyvault/Azure.Security.KeyVault.Secrets/src/SecretClientBuilderExtensions.cs @@ -2,6 +2,7 @@ // Licensed under the MIT License. using System; +using System.Diagnostics.CodeAnalysis; using Azure.Core.Extensions; using Azure.Security.KeyVault.Secrets; @@ -24,6 +25,8 @@ public static IAzureClientBuilder AddSecretCl /// /// Registers a instance with connection options loaded from the provided instance. /// + [RequiresUnreferencedCode("Binding strongly typed objects to configuration values is not supported with trimming. Use the Configuration Binder Source Generator (EnableConfigurationBindingGenerator=true) instead.")] + [RequiresDynamicCode("Binding strongly typed objects to configuration values requires generating dynamic code at runtime, for example instantiating generic types. Use the Configuration Binder Source Generator (EnableConfigurationBindingGenerator=true) instead.")] public static IAzureClientBuilder AddSecretClient(this TBuilder builder, TConfiguration configuration) where TBuilder : IAzureClientFactoryBuilderWithConfiguration { diff --git a/sdk/keyvault/Azure.Security.KeyVault.Secrets/tests/compatibility/ExpectedAotWarnings.txt b/sdk/keyvault/Azure.Security.KeyVault.Secrets/tests/compatibility/ExpectedAotWarnings.txt deleted file mode 100644 index 495f863729ed..000000000000 --- a/sdk/keyvault/Azure.Security.KeyVault.Secrets/tests/compatibility/ExpectedAotWarnings.txt +++ /dev/null @@ -1,2 +0,0 @@ -.*/Azure\.Security\.KeyVault\.Secrets.src.SecretClientBuilderExtensions\.cs\(30\): Trim analysis warning IL2026: Microsoft\.Extensions\.Azure\.SecretClientBuilderExtensions\.AddSecretClient\(TBuilder,!!1\): Using member 'Azure\.Core\.Extensions\.IAzureClientFactoryBuilderWithConfiguration`1\.RegisterClientFactory\(TConfiguration\)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code\. Binding strongly typed objects to configuration values is not supported with trimming\. Use the Configuration Binder Source Generator \(EnableConfigurationBindingGenerator=true\) instead\. -.*/Azure\.Security\.KeyVault\.Secrets.src.SecretClientBuilderExtensions\.cs\(30\): AOT analysis warning IL3050: Microsoft\.Extensions\.Azure\.SecretClientBuilderExtensions\.AddSecretClient\(TBuilder,!!1\): Using member 'Azure\.Core\.Extensions\.IAzureClientFactoryBuilderWithConfiguration`1\.RegisterClientFactory\(TConfiguration\)' which has 'RequiresDynamicCodeAttribute' can break functionality when AOT compiling\. Binding strongly typed objects to configuration values requires generating dynamic code at runtime, for example instantiating generic types\. Use the Configuration Binder Source Generator \(EnableConfigurationBindingGenerator=true\) instead\. \ No newline at end of file diff --git a/sdk/keyvault/ci.yml b/sdk/keyvault/ci.yml index ec6e09fa88b1..032c009e7565 100644 --- a/sdk/keyvault/ci.yml +++ b/sdk/keyvault/ci.yml @@ -42,4 +42,4 @@ extends: CheckAOTCompat: true AOTTestInputs: - ArtifactName: Azure.Security.KeyVault.Secrets - ExpectedWarningsFilepath: /Azure.Security.KeyVault.Secrets/tests/compatibility/ExpectedAotWarnings.txt \ No newline at end of file + ExpectedWarningsFilepath: None