diff --git a/sdk/core/System.ClientModel/CHANGELOG.md b/sdk/core/System.ClientModel/CHANGELOG.md index 6878bacb6092..e924704c34ea 100644 --- a/sdk/core/System.ClientModel/CHANGELOG.md +++ b/sdk/core/System.ClientModel/CHANGELOG.md @@ -10,6 +10,8 @@ ### Other Changes +- Removed implicit cast from `string` to `ApiKeyCredential`. + ## 1.1.0-beta.7 (2024-08-14) ### Features Added diff --git a/sdk/core/System.ClientModel/api/System.ClientModel.net6.0.cs b/sdk/core/System.ClientModel/api/System.ClientModel.net6.0.cs index 38a53857153d..a510e31d07d7 100644 --- a/sdk/core/System.ClientModel/api/System.ClientModel.net6.0.cs +++ b/sdk/core/System.ClientModel/api/System.ClientModel.net6.0.cs @@ -4,7 +4,6 @@ public partial class ApiKeyCredential { public ApiKeyCredential(string key) { } public void Deconstruct(out string key) { throw null; } - public static implicit operator System.ClientModel.ApiKeyCredential (string key) { throw null; } public void Update(string key) { } } public abstract partial class AsyncCollectionResult : System.ClientModel.ClientResult, System.Collections.Generic.IAsyncEnumerable diff --git a/sdk/core/System.ClientModel/api/System.ClientModel.netstandard2.0.cs b/sdk/core/System.ClientModel/api/System.ClientModel.netstandard2.0.cs index 2a716c72f50d..ad3a7a378fc0 100644 --- a/sdk/core/System.ClientModel/api/System.ClientModel.netstandard2.0.cs +++ b/sdk/core/System.ClientModel/api/System.ClientModel.netstandard2.0.cs @@ -4,7 +4,6 @@ public partial class ApiKeyCredential { public ApiKeyCredential(string key) { } public void Deconstruct(out string key) { throw null; } - public static implicit operator System.ClientModel.ApiKeyCredential (string key) { throw null; } public void Update(string key) { } } public abstract partial class AsyncCollectionResult : System.ClientModel.ClientResult, System.Collections.Generic.IAsyncEnumerable diff --git a/sdk/core/System.ClientModel/src/Convenience/ApiKeyCredential.cs b/sdk/core/System.ClientModel/src/Convenience/ApiKeyCredential.cs index 25968d7b4550..5549597debbb 100644 --- a/sdk/core/System.ClientModel/src/Convenience/ApiKeyCredential.cs +++ b/sdk/core/System.ClientModel/src/Convenience/ApiKeyCredential.cs @@ -65,7 +65,4 @@ public void Update(string key) Volatile.Write(ref _key, key); } - - /// Converts a string to an . - public static implicit operator ApiKeyCredential(string key) => new(key); } diff --git a/sdk/core/System.ClientModel/tests/Pipeline/ApiKeyAuthenticationPolicyTests.cs b/sdk/core/System.ClientModel/tests/Pipeline/ApiKeyAuthenticationPolicyTests.cs index e5638343fbfb..874e6ba0c7b6 100644 --- a/sdk/core/System.ClientModel/tests/Pipeline/ApiKeyAuthenticationPolicyTests.cs +++ b/sdk/core/System.ClientModel/tests/Pipeline/ApiKeyAuthenticationPolicyTests.cs @@ -16,19 +16,6 @@ public ApiKeyAuthenticationPolicyTests(bool isAsync) : base(isAsync) { } - [Test] - public void CanImplicitlyCastApiKeyCredential() - { - string keyValue = "test_key"; - ApiKeyCredential credential1 = new(keyValue); - ApiKeyCredential credential2 = keyValue; - - credential1.Deconstruct(out string deconstructed1); - credential2.Deconstruct(out string deconstructed2); - - Assert.AreEqual(deconstructed1, deconstructed2); - } - [Test] public async Task HeaderPolicySetsKey() {