Skip to content

Conversation

@TimothyMothra
Copy link

@TimothyMothra TimothyMothra commented Jul 19, 2024

Fixes: #44889

Our mapping for LiveMetrics dependencies was incorrect.

  • For known dependencies, the mappings didn't match Exporter.
  • For unknown or manual dependencies, several fields were left unset.
    A user reported that IsSuccess was left as default value false and were incorrectly shown on the "Failed Dependencies" graph.

Changes

  • Update all dependency types to match Exporter.
  • Set additional properties for manual/unknown dependencies.

Notes

Application Insights defines mapping the DependencyTelemetry to DependencyDocument.
https://github.com/microsoft/ApplicationInsights-dotnet/blob/f5377f2e8f1d3ae557c1064e8028c31b34876f9c/WEB/Src/PerformanceCollector/PerformanceCollector/QuickPulseTelemetryProcessor.cs#L222

private static ITelemetryDocument ConvertDependencyToTelemetryDocument(DependencyTelemetry dependencyTelemetry)
{
    ITelemetryDocument telemetryDocument = new DependencyTelemetryDocument()
    {
        Name = TruncateValue(dependencyTelemetry.Name),
        Success = dependencyTelemetry.Success,
        Duration = dependencyTelemetry.Duration,
        ResultCode = dependencyTelemetry.ResultCode,
        CommandName = TruncateValue(dependencyTelemetry.Data),
    };
}

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.Monitor.OpenTelemetry.AspNetCore

@TimothyMothra TimothyMothra marked this pull request as draft July 31, 2024 17:46
@TimothyMothra
Copy link
Author

Changed this to Draft while I'm investigating other mappings

@TimothyMothra TimothyMothra changed the title [AzureMonitorDistro] fix for LiveMetrics and manual Dependencies [AzureMonitorDistro] fix for LiveMetrics Dependencies Aug 5, 2024
@TimothyMothra TimothyMothra marked this pull request as ready for review August 5, 2024 22:34
Timothy Mothra Lee (from Dev Box) added 2 commits August 5, 2024 15:40
@TimothyMothra
Copy link
Author

@rajkumar-rangaraj this is ready for review

Timothy Mothra Lee (from Dev Box) added 2 commits August 16, 2024 14:31
@TimothyMothra TimothyMothra merged commit 91dc3f1 into main Aug 23, 2024
@TimothyMothra TimothyMothra deleted the tilee/202407_fixLiveMetrics_manualDependency branch August 23, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Monitor - Distro Monitor OpenTelemetry Distro

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Start an internal activity raise a Dependency Call Failure in Live metrics

5 participants