Sync eng/common directory with azure-sdk-tools for PR 8475 #44658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azure-sdk
added
EngSys
… container registry tests which I need to re-record
scbedd
requested review from
ArthurMa1978,
JoshLove-msft,
KrzysztofCwalina,
annelo-msft,
christothes,
jsquire,
m-nash,
pallavit and
tg-msft
as code owners
Member
|
This PR breaks a couple container registry recordings. I was entirely aware of this, but it was necessary to get this fix out. All other languages (aside from JS which I'm investigating tomorrow) have had recordings updated. Expecting this one to be green after the rebuild as well. |
scbedd
approved these changes
Jun 21, 2024
tejasm-microsoft
pushed a commit
to tejasm-microsoft/azure-sdk-for-net
that referenced
this pull request
Jul 22, 2024
* update the target version of the proxy * use the new version of the proxy. this is a breaking change for a few container registry tests which I need to re-record * add re-recorded tests! --------- Co-authored-by: Scott Beddall (from Dev Box) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#8475 See eng/common workflow