Getting update management changes result from PR #3095#4345
Merged
dsgouda merged 3 commits intoAzure:psSdkJson6from May 23, 2018
Merged
Getting update management changes result from PR #3095#4345dsgouda merged 3 commits intoAzure:psSdkJson6from
dsgouda merged 3 commits intoAzure:psSdkJson6from
Conversation
Contributor
Author
|
@dsgouda thanks! will update... |
dsgouda
suggested changes
May 21, 2018
Contributor
dsgouda
left a comment
There was a problem hiding this comment.
There are some additive changes made here, please bump the version to 3.0.3-preview in the csproj
Contributor
|
Looks good apart from the minor comment |
Contributor
Author
|
cool! will add this, thanks!! |
Contributor
|
@finiteattractor Perhaps I forgot to mention but, we need to update the AssemblyInfo.cs here so that |
Contributor
Author
|
Good catch Thanks! will update. |
dsgouda
approved these changes
May 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating generated code based of swagger PR:
Azure/azure-rest-api-specs#3095
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.