-
Notifications
You must be signed in to change notification settings - Fork 5.1k
[AzureMonitorDistro] resync vendored code #42522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
API change check API changes are not detected in this pull request. |
I don't think that's the right way to think about this issue. The right model IMHO is #42479 (comment) |
@reyang please re-review. I resynced the files using the model discussed. I've updated this PR and the description. |
The description/approach looks good to me, Thanks! Don't get blocked on me (I don't plan to spend time to compare files and approve the PR). |
rajkumar-rangaraj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Please have Vishwesh review the PR before the merge.
vishweshbankwar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* cleanup copyright * update SqlClient
Follow up to #42479 (comment)
Because we've been manually syncing vendored files, some of these files are out of sync with the OpenTelemetry repo. I've resynced all files.
Explanation of Changes
// <copyright file="FILENAME" company="OpenTelemetry Authors">from all vendored files.This was a mistake made when manually syncing files.
SqlClient_TracerProviderBuilderExtensions. The "SqlClient_" prefix was necessary when we had multiple vendored instrumentation libraries with identical class names/namespaces. This is no longer needed.Steps followed to Sync Vendored code
OpenTelemetry.Instrumentation.SqlClient2a. Clone the OpenTelemetry.NET Repository
Azure.Monitor.OpenTelemetry.AspNetCore'sVendoringdirectory:OpenTelemetry.Instrumentation.SqlClientSharedOpenTelemetry.ResourceDetectors.Azure3a. Clone the OpenTelemetry.NET Contrib Repository
Azure.Monitor.OpenTelemetry.AspNetCore'sVendoringdirectory:OpenTelemetry.ResourceDetectors.AzureShared#nullable enabletoOpenTelemetry.ResourceDetoctors.Azurefiles. OurAzure.Monitor.OpenTelemetry.AspNetCoreproject does not yet support nullables.#pragma warning disableAZC0102andAZC0104toAzure.VmMetaDataRequestor.cs. These are code standards that only exist in this Azure SDK reop.