Skip to content

Conversation

@sudhansu88
Copy link
Contributor

Description


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

Copy link
Contributor

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, but looking at the directory names, make sure you are not getting into MAX_PATH issues during build.
Also I have seen you have not pulled upstream changes to these project files.
Almost all project files need the following header import and footer imports as you see in this file
https://github.com/sudhansu88/azure-sdk-for-net/blob/psSdkJson6/src/SDKs/Compute/Management.Compute/Microsoft.Azure.Management.Compute.csproj

Also make sure you don't explicitly add any directories or files to the sdk project.
I see couple of places you have added Folder Include="Properties" (an additional ItemGroup). Please remove any ItemGroup that you don't need.

Copy link
Contributor

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes required. Once done this PR is good to be merged.

<Project Sdk="Microsoft.NET.Sdk">
<!-- Please do not move/edit code below this line -->
<Import Project="$([MSBuild]::GetPathOfFileAbove('AzSdk.reference.props'))" />
<!-- Please do not move/edit code below this line -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sudhansu88 this should be
Please do not move/edit code above this line and it says "below"
Can you make the change in all the csproj files.

@sudhansu88
Copy link
Contributor Author

Updated Comment as per suggestion

@brjohnstmsft
Copy link
Member

@sudhansu88 Please include the specific name of the service in your PR titles. There is more than one "Search API/SDK" in this repo. Thanks!

@sudhansu88 sudhansu88 changed the title Folder restructure for Search API SDKs Folder restructure for Search API SDKs [ EntitySearch,WebSearch,ImageSearch,VideoSearch,SpellCheck,CustomSearch ] Dec 12, 2017
@sudhansu88
Copy link
Contributor Author

sudhansu88 commented Dec 12, 2017

@brjohnstmsft : Updated all SDK names. We ares omewhat blocked on this. Could you please help merge ?

@shahabhijeet shahabhijeet merged commit 03dbdba into Azure:psSdkJson6 Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants