From 450b70cee4bf0fa1587a73fee9994d06dc80eb2a Mon Sep 17 00:00:00 2001 From: Timothy Mothra Lee Date: Wed, 2 Aug 2023 13:40:09 -0700 Subject: [PATCH 1/2] update Options class --- .../src/AzureMonitorOptions.cs | 4 ++-- .../Azure.Monitor.OpenTelemetry.Exporter/CHANGELOG.md | 3 +++ .../src/AzureMonitorExporterOptions.cs | 9 ++------- 3 files changed, 7 insertions(+), 9 deletions(-) diff --git a/sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/src/AzureMonitorOptions.cs b/sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/src/AzureMonitorOptions.cs index 89938a80a322..00793c3d7b69 100644 --- a/sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/src/AzureMonitorOptions.cs +++ b/sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/src/AzureMonitorOptions.cs @@ -17,7 +17,7 @@ public class AzureMonitorOptions : ClientOptions /// The Connection String provides users with a single configuration setting to identify the Azure Monitor resource and endpoint. /// /// - /// (https://docs.microsoft.com/azure/azure-monitor/app/sdk-connection-string). + /// . /// public string ConnectionString { get; set; } @@ -27,7 +27,7 @@ public class AzureMonitorOptions : ClientOptions /// and Instrumentation Key from the Connection String will be used. /// /// - /// https://learn.microsoft.com/en-us/azure/azure-monitor/app/sdk-connection-string?tabs=net#is-the-connection-string-a-secret + /// . /// public TokenCredential Credential { get; set; } diff --git a/sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/CHANGELOG.md b/sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/CHANGELOG.md index 672144f93022..2a505ec9897a 100644 --- a/sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/CHANGELOG.md +++ b/sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/CHANGELOG.md @@ -9,6 +9,9 @@ * Location ip on server spans will now be set using `client.address` tag key on activity instead of `http.client_ip`. ([#37707](https://github.com/Azure/azure-sdk-for-net/pull/37707)) +* Removing `ServiceVersion.V2020_09_15_Preview`. This is no longer in use and + the exporter has already defaulted to the latest `ServiceVersion.v2_1`. + ([]()) ### Bugs Fixed diff --git a/sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/AzureMonitorExporterOptions.cs b/sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/AzureMonitorExporterOptions.cs index 267c82d4fbff..ceeda90ec459 100644 --- a/sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/AzureMonitorExporterOptions.cs +++ b/sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/AzureMonitorExporterOptions.cs @@ -21,7 +21,7 @@ public class AzureMonitorExporterOptions : ClientOptions /// The Connection String provides users with a single configuration setting to identify the Azure Monitor resource and endpoint. /// /// - /// (https://docs.microsoft.com/azure/azure-monitor/app/sdk-connection-string). + /// . /// public string? ConnectionString { get; set; } @@ -65,12 +65,7 @@ public AzureMonitorExporterOptions(ServiceVersion version = LatestVersion) public enum ServiceVersion { /// - /// (https://github.com/Azure/azure-rest-api-specs/blob/master/specification/applicationinsights/data-plane/Monitor.Exporters/preview/2020-09-15_Preview/swagger.json). - /// - V2020_09_15_Preview = 1, - - /// - /// (https://github.com/Azure/azure-rest-api-specs/blob/master/specification/applicationinsights/data-plane/Monitor.Exporters/preview/v2.1/swagger.json). + /// . /// v2_1 = 2, } From 4b643a7cf5c9afc7197bc1d30e31553e3c4670d5 Mon Sep 17 00:00:00 2001 From: Timothy Mothra Lee Date: Wed, 2 Aug 2023 13:46:33 -0700 Subject: [PATCH 2/2] changelog --- sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/CHANGELOG.md b/sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/CHANGELOG.md index 2a505ec9897a..a33900e269de 100644 --- a/sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/CHANGELOG.md +++ b/sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/CHANGELOG.md @@ -11,7 +11,7 @@ ([#37707](https://github.com/Azure/azure-sdk-for-net/pull/37707)) * Removing `ServiceVersion.V2020_09_15_Preview`. This is no longer in use and the exporter has already defaulted to the latest `ServiceVersion.v2_1`. - ([]()) + ([#37993](https://github.com/Azure/azure-sdk-for-net/pull/37993)) ### Bugs Fixed