From 64ba6bdb39f5d6dd65d79d539d65d997b247a77d Mon Sep 17 00:00:00 2001 From: Keerthi Thatipally Date: Tue, 21 Jun 2022 10:52:31 -0500 Subject: [PATCH 1/5] Azure Lab Services Minor version update to 4.1.0: Bug fix - LabServicesClient now exposes public constructor --- .../mgmtmetadata/labservices_resource-manager.txt | 14 +++++++------- .../src/Generated/LabServicesClient.cs | 10 +++++----- .../src/Generated/Models/RecurrencePattern.cs | 15 ++++++--------- .../src/Generated/SdkInfo_LabServicesClient.cs | 8 ++++---- .../Microsoft.Azure.Management.LabServices.csproj | 4 ++-- .../src/Properties/AssemblyInfo.cs | 2 +- 6 files changed, 25 insertions(+), 28 deletions(-) diff --git a/eng/mgmt/mgmtmetadata/labservices_resource-manager.txt b/eng/mgmt/mgmtmetadata/labservices_resource-manager.txt index 97833f65050c..57fbfb726bd0 100644 --- a/eng/mgmt/mgmtmetadata/labservices_resource-manager.txt +++ b/eng/mgmt/mgmtmetadata/labservices_resource-manager.txt @@ -1,15 +1,15 @@ -Installing AutoRest version: v2 +Installing AutoRest version: v2 AutoRest installed successfully. Commencing code generation Generating CSharp code Executing AutoRest command -cmd.exe /c autorest.cmd https://github.com/Azure/azure-rest-api-specs/blob/main/specification/labservices/resource-manager/readme.md --csharp --version=v2 --reflect-api-versions --csharp-sdks-folder=C:\Repos\azure-sdk-for-net\sdk -Autorest CSharp Version: 2.3.91 -2022-01-26 21:43:34 UTC +cmd.exe /c autorest.cmd https://github.com/Azure/azure-rest-api-specs/blob/main/specification/labservices/resource-manager/readme.md --csharp --version=2.0.4421 --reflect-api-versions --csharp-sdks-folder=C:\Projects\azure-sdk-for-net\sdk +Autorest CSharp Version: 2.3.82 +2022-06-21 14:52:51 UTC Azure-rest-api-specs repository information GitHub fork: Azure Branch: main -Commit: 679887ace44697c726aba8d2814ee415a5d25e6f +Commit: f68e478437a9065651c982788769337fc4d8fb37 AutoRest information -Requested version: v2 -Bootstrapper version: autorest@3.4.0 +Requested version: 2.0.4421 +Bootstrapper version: autorest@2.0.4413 diff --git a/sdk/labservices/Microsoft.Azure.Management.LabServices/src/Generated/LabServicesClient.cs b/sdk/labservices/Microsoft.Azure.Management.LabServices/src/Generated/LabServicesClient.cs index 41b5166991ee..b1e8c767aa41 100644 --- a/sdk/labservices/Microsoft.Azure.Management.LabServices/src/Generated/LabServicesClient.cs +++ b/sdk/labservices/Microsoft.Azure.Management.LabServices/src/Generated/LabServicesClient.cs @@ -216,7 +216,7 @@ protected LabServicesClient(System.Uri baseUri, HttpClientHandler rootHandler, p /// /// Thrown when a required parameter is null /// - internal LabServicesClient(ServiceClientCredentials credentials, params DelegatingHandler[] handlers) : this(handlers) + public LabServicesClient(ServiceClientCredentials credentials, params DelegatingHandler[] handlers) : this(handlers) { if (credentials == null) { @@ -243,7 +243,7 @@ internal LabServicesClient(ServiceClientCredentials credentials, params Delegati /// /// Thrown when a required parameter is null /// - internal LabServicesClient(ServiceClientCredentials credentials, HttpClient httpClient, bool disposeHttpClient) : this(httpClient, disposeHttpClient) + public LabServicesClient(ServiceClientCredentials credentials, HttpClient httpClient, bool disposeHttpClient) : this(httpClient, disposeHttpClient) { if (credentials == null) { @@ -271,7 +271,7 @@ internal LabServicesClient(ServiceClientCredentials credentials, HttpClient http /// /// Thrown when a required parameter is null /// - internal LabServicesClient(ServiceClientCredentials credentials, HttpClientHandler rootHandler, params DelegatingHandler[] handlers) : this(rootHandler, handlers) + public LabServicesClient(ServiceClientCredentials credentials, HttpClientHandler rootHandler, params DelegatingHandler[] handlers) : this(rootHandler, handlers) { if (credentials == null) { @@ -299,7 +299,7 @@ internal LabServicesClient(ServiceClientCredentials credentials, HttpClientHandl /// /// Thrown when a required parameter is null /// - internal LabServicesClient(System.Uri baseUri, ServiceClientCredentials credentials, params DelegatingHandler[] handlers) : this(handlers) + public LabServicesClient(System.Uri baseUri, ServiceClientCredentials credentials, params DelegatingHandler[] handlers) : this(handlers) { if (baseUri == null) { @@ -335,7 +335,7 @@ internal LabServicesClient(System.Uri baseUri, ServiceClientCredentials credenti /// /// Thrown when a required parameter is null /// - internal LabServicesClient(System.Uri baseUri, ServiceClientCredentials credentials, HttpClientHandler rootHandler, params DelegatingHandler[] handlers) : this(rootHandler, handlers) + public LabServicesClient(System.Uri baseUri, ServiceClientCredentials credentials, HttpClientHandler rootHandler, params DelegatingHandler[] handlers) : this(rootHandler, handlers) { if (baseUri == null) { diff --git a/sdk/labservices/Microsoft.Azure.Management.LabServices/src/Generated/Models/RecurrencePattern.cs b/sdk/labservices/Microsoft.Azure.Management.LabServices/src/Generated/Models/RecurrencePattern.cs index 3907c87b3cc2..06b03e08da93 100644 --- a/sdk/labservices/Microsoft.Azure.Management.LabServices/src/Generated/Models/RecurrencePattern.cs +++ b/sdk/labservices/Microsoft.Azure.Management.LabServices/src/Generated/Models/RecurrencePattern.cs @@ -95,16 +95,13 @@ public RecurrencePattern() /// public virtual void Validate() { - if (Interval != null) + if (Interval > 365) { - if (Interval > 365) - { - throw new ValidationException(ValidationRules.InclusiveMaximum, "Interval", 365); - } - if (Interval < 1) - { - throw new ValidationException(ValidationRules.InclusiveMinimum, "Interval", 1); - } + throw new ValidationException(ValidationRules.InclusiveMaximum, "Interval", 365); + } + if (Interval < 1) + { + throw new ValidationException(ValidationRules.InclusiveMinimum, "Interval", 1); } } } diff --git a/sdk/labservices/Microsoft.Azure.Management.LabServices/src/Generated/SdkInfo_LabServicesClient.cs b/sdk/labservices/Microsoft.Azure.Management.LabServices/src/Generated/SdkInfo_LabServicesClient.cs index 60c344681b87..3187ec745d04 100644 --- a/sdk/labservices/Microsoft.Azure.Management.LabServices/src/Generated/SdkInfo_LabServicesClient.cs +++ b/sdk/labservices/Microsoft.Azure.Management.LabServices/src/Generated/SdkInfo_LabServicesClient.cs @@ -33,12 +33,12 @@ public static IEnumerable> ApiInfo_LabServicesClie } } // BEGIN: Code Generation Metadata Section - public static readonly String AutoRestVersion = "v2"; - public static readonly String AutoRestBootStrapperVersion = "autorest@3.4.0"; - public static readonly String AutoRestCmdExecuted = "cmd.exe /c autorest.cmd https://github.com/Azure/azure-rest-api-specs/blob/main/specification/labservices/resource-manager/readme.md --csharp --version=v2 --reflect-api-versions --csharp-sdks-folder=C:\\Repos\\azure-sdk-for-net\\sdk"; + public static readonly String AutoRestVersion = "2.0.4421"; + public static readonly String AutoRestBootStrapperVersion = "autorest@2.0.4413"; + public static readonly String AutoRestCmdExecuted = "cmd.exe /c autorest.cmd https://github.com/Azure/azure-rest-api-specs/blob/main/specification/labservices/resource-manager/readme.md --csharp --version=2.0.4421 --reflect-api-versions --csharp-sdks-folder=C:\\Projects\\azure-sdk-for-net\\sdk"; public static readonly String GithubForkName = "Azure"; public static readonly String GithubBranchName = "main"; - public static readonly String GithubCommidId = "679887ace44697c726aba8d2814ee415a5d25e6f"; + public static readonly String GithubCommidId = "f68e478437a9065651c982788769337fc4d8fb37"; public static readonly String CodeGenerationErrors = ""; public static readonly String GithubRepoName = "azure-rest-api-specs"; // END: Code Generation Metadata Section diff --git a/sdk/labservices/Microsoft.Azure.Management.LabServices/src/Microsoft.Azure.Management.LabServices.csproj b/sdk/labservices/Microsoft.Azure.Management.LabServices/src/Microsoft.Azure.Management.LabServices.csproj index 18304d26389a..5a5477b03958 100644 --- a/sdk/labservices/Microsoft.Azure.Management.LabServices/src/Microsoft.Azure.Management.LabServices.csproj +++ b/sdk/labservices/Microsoft.Azure.Management.LabServices/src/Microsoft.Azure.Management.LabServices.csproj @@ -4,12 +4,12 @@ - 4.0.0 + 4.1.0 Microsoft.Azure.Management.LabServices Microsoft.Azure.Management.LabServices Microsoft.Azure.Management.LabServices LabServices;ManagedLabs; - Release api version 2021-11-15-preview. + Minor Version Update - Bugs Fixed:LabServicesClient constructors are now public {B2143F8C-A1B8-4042-ACAB-CB7797E24C9F} diff --git a/sdk/labservices/Microsoft.Azure.Management.LabServices/src/Properties/AssemblyInfo.cs b/sdk/labservices/Microsoft.Azure.Management.LabServices/src/Properties/AssemblyInfo.cs index 45cb5b47361d..eab3a47e2729 100644 --- a/sdk/labservices/Microsoft.Azure.Management.LabServices/src/Properties/AssemblyInfo.cs +++ b/sdk/labservices/Microsoft.Azure.Management.LabServices/src/Properties/AssemblyInfo.cs @@ -7,7 +7,7 @@ [assembly: AssemblyTitle("Microsoft Azure Lab Services Management Library")] [assembly: AssemblyDescription("Provides management functionality for Microsoft Azure Lab Services Resources.")] [assembly: AssemblyVersion("4.0.0.0")] -[assembly: AssemblyFileVersion("4.0.0.0")] +[assembly: AssemblyFileVersion("4.1.0.0")] [assembly: AssemblyConfiguration("")] [assembly: AssemblyCompany("Microsoft")] [assembly: AssemblyProduct("Microsoft Azure .NET SDK")] From 387a07bf15867ee53113791db293468a0af44ff1 Mon Sep 17 00:00:00 2001 From: Keerthi Thatipally Date: Tue, 21 Jun 2022 12:43:20 -0500 Subject: [PATCH 2/5] Azure Lab Services: updated assemblyVersion --- .../src/Properties/AssemblyInfo.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/labservices/Microsoft.Azure.Management.LabServices/src/Properties/AssemblyInfo.cs b/sdk/labservices/Microsoft.Azure.Management.LabServices/src/Properties/AssemblyInfo.cs index eab3a47e2729..08af150e1f0a 100644 --- a/sdk/labservices/Microsoft.Azure.Management.LabServices/src/Properties/AssemblyInfo.cs +++ b/sdk/labservices/Microsoft.Azure.Management.LabServices/src/Properties/AssemblyInfo.cs @@ -6,7 +6,7 @@ [assembly: AssemblyTitle("Microsoft Azure Lab Services Management Library")] [assembly: AssemblyDescription("Provides management functionality for Microsoft Azure Lab Services Resources.")] -[assembly: AssemblyVersion("4.0.0.0")] +[assembly: AssemblyVersion("4.1.0.0")] [assembly: AssemblyFileVersion("4.1.0.0")] [assembly: AssemblyConfiguration("")] [assembly: AssemblyCompany("Microsoft")] From b88b28606c79a96153e9f013f636b46a5908374d Mon Sep 17 00:00:00 2001 From: Keerthi Thatipally Date: Wed, 6 Jul 2022 22:36:20 -0500 Subject: [PATCH 3/5] Updates to address PR comments --- .../src/Microsoft.Azure.Management.LabServices.csproj | 7 ++++--- .../src/Properties/AssemblyInfo.cs | 4 ++-- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/sdk/labservices/Microsoft.Azure.Management.LabServices/src/Microsoft.Azure.Management.LabServices.csproj b/sdk/labservices/Microsoft.Azure.Management.LabServices/src/Microsoft.Azure.Management.LabServices.csproj index 5a5477b03958..fb8fc4c93f23 100644 --- a/sdk/labservices/Microsoft.Azure.Management.LabServices/src/Microsoft.Azure.Management.LabServices.csproj +++ b/sdk/labservices/Microsoft.Azure.Management.LabServices/src/Microsoft.Azure.Management.LabServices.csproj @@ -4,13 +4,14 @@ - 4.1.0 + 1.0.0-beta.1 Microsoft.Azure.Management.LabServices Microsoft.Azure.Management.LabServices Microsoft.Azure.Management.LabServices LabServices;ManagedLabs; - Minor Version Update - Bugs Fixed:LabServicesClient constructors are now public - {B2143F8C-A1B8-4042-ACAB-CB7797E24C9F} + Azure management client SDK for Azure resource provider Microsoft.Azure.Management.LabServices. + This is a beta preview vesion. Bugs Fixed:LabServicesClient constructors are now public + {B2143F8C-A1B8-4042-ACAB-CB7797E24C9F} $(SdkTargetFx) diff --git a/sdk/labservices/Microsoft.Azure.Management.LabServices/src/Properties/AssemblyInfo.cs b/sdk/labservices/Microsoft.Azure.Management.LabServices/src/Properties/AssemblyInfo.cs index 08af150e1f0a..80a9cfd52255 100644 --- a/sdk/labservices/Microsoft.Azure.Management.LabServices/src/Properties/AssemblyInfo.cs +++ b/sdk/labservices/Microsoft.Azure.Management.LabServices/src/Properties/AssemblyInfo.cs @@ -6,8 +6,8 @@ [assembly: AssemblyTitle("Microsoft Azure Lab Services Management Library")] [assembly: AssemblyDescription("Provides management functionality for Microsoft Azure Lab Services Resources.")] -[assembly: AssemblyVersion("4.1.0.0")] -[assembly: AssemblyFileVersion("4.1.0.0")] +[assembly: AssemblyVersion("1.0.0")] +[assembly: AssemblyFileVersion("1.0.0-beta.1")] [assembly: AssemblyConfiguration("")] [assembly: AssemblyCompany("Microsoft")] [assembly: AssemblyProduct("Microsoft Azure .NET SDK")] From d59f8611dba1380388611c306bcaf13b14012bc7 Mon Sep 17 00:00:00 2001 From: Keerthi Thatipally Date: Mon, 11 Jul 2022 22:58:31 -0500 Subject: [PATCH 4/5] Updates to address PR comments to change the version from 1.0.0-beta.1 to 4.1.0-beta.1 --- .../Microsoft.Azure.Management.LabServices/CHANGELOG.md | 6 ++++++ .../src/Microsoft.Azure.Management.LabServices.csproj | 2 +- .../src/Properties/AssemblyInfo.cs | 4 ++-- 3 files changed, 9 insertions(+), 3 deletions(-) create mode 100644 sdk/labservices/Microsoft.Azure.Management.LabServices/CHANGELOG.md diff --git a/sdk/labservices/Microsoft.Azure.Management.LabServices/CHANGELOG.md b/sdk/labservices/Microsoft.Azure.Management.LabServices/CHANGELOG.md new file mode 100644 index 000000000000..2a3881153883 --- /dev/null +++ b/sdk/labservices/Microsoft.Azure.Management.LabServices/CHANGELOG.md @@ -0,0 +1,6 @@ +# Release History + +## 4.1.0-preview (2022-07) +- This release corresponds to the 2021-11-15-preview API version. +- Bugs Fixed:LabServicesClient constructors are now public + diff --git a/sdk/labservices/Microsoft.Azure.Management.LabServices/src/Microsoft.Azure.Management.LabServices.csproj b/sdk/labservices/Microsoft.Azure.Management.LabServices/src/Microsoft.Azure.Management.LabServices.csproj index fb8fc4c93f23..5f3c40e8d814 100644 --- a/sdk/labservices/Microsoft.Azure.Management.LabServices/src/Microsoft.Azure.Management.LabServices.csproj +++ b/sdk/labservices/Microsoft.Azure.Management.LabServices/src/Microsoft.Azure.Management.LabServices.csproj @@ -4,7 +4,7 @@ - 1.0.0-beta.1 + 4.1.0-beta.1 Microsoft.Azure.Management.LabServices Microsoft.Azure.Management.LabServices Microsoft.Azure.Management.LabServices diff --git a/sdk/labservices/Microsoft.Azure.Management.LabServices/src/Properties/AssemblyInfo.cs b/sdk/labservices/Microsoft.Azure.Management.LabServices/src/Properties/AssemblyInfo.cs index 80a9cfd52255..55809f2c947a 100644 --- a/sdk/labservices/Microsoft.Azure.Management.LabServices/src/Properties/AssemblyInfo.cs +++ b/sdk/labservices/Microsoft.Azure.Management.LabServices/src/Properties/AssemblyInfo.cs @@ -6,8 +6,8 @@ [assembly: AssemblyTitle("Microsoft Azure Lab Services Management Library")] [assembly: AssemblyDescription("Provides management functionality for Microsoft Azure Lab Services Resources.")] -[assembly: AssemblyVersion("1.0.0")] -[assembly: AssemblyFileVersion("1.0.0-beta.1")] +[assembly: AssemblyVersion("4.1.0")] +[assembly: AssemblyFileVersion("4.1.0-beta.1")] [assembly: AssemblyConfiguration("")] [assembly: AssemblyCompany("Microsoft")] [assembly: AssemblyProduct("Microsoft Azure .NET SDK")] From d887ba5f903676edf8a88f3878ea901b1a5ab7a2 Mon Sep 17 00:00:00 2001 From: Keerthi Thatipally Date: Tue, 12 Jul 2022 00:20:06 -0500 Subject: [PATCH 5/5] Updates to address PR comments - removed extra space --- .../Microsoft.Azure.Management.LabServices/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/labservices/Microsoft.Azure.Management.LabServices/CHANGELOG.md b/sdk/labservices/Microsoft.Azure.Management.LabServices/CHANGELOG.md index 2a3881153883..529ec19f18b1 100644 --- a/sdk/labservices/Microsoft.Azure.Management.LabServices/CHANGELOG.md +++ b/sdk/labservices/Microsoft.Azure.Management.LabServices/CHANGELOG.md @@ -2,5 +2,5 @@ ## 4.1.0-preview (2022-07) - This release corresponds to the 2021-11-15-preview API version. -- Bugs Fixed:LabServicesClient constructors are now public +- Bugs Fixed:LabServicesClient constructors are now public