Use arm template parameters as sole input for live test environment variables #25250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbp
requested review from
Mohit-Chakraborty,
arv100kri,
bleroy,
brjohnstmsft,
christothes,
jsquire,
kasun04,
serkantkaraca,
sjkwak and
tg-msft
as code owners
ghost
added
benbp
added
the
Central-EngSys
Member
Author
|
/azp run net - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run net - identity - tests-weekly |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run net - tables - tests-weekly |
|
Azure Pipelines successfully started running 1 pipeline(s). |
weshaggard
approved these changes
Nov 10, 2021
jsquire
approved these changes
Nov 12, 2021
Member
jsquire
left a comment
jsquire
left a comment
There was a problem hiding this comment.
The Event Hubs bits look good to me.
christothes
reviewed
Nov 12, 2021
benbp
force-pushed
the
benbp/live-test-vars
branch
from
c9a8c0f to
a6f6774
Compare
Member
Author
|
/azp run net - tables - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run net - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run net - identity - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
benbp
force-pushed
the
benbp/live-test-vars
branch
from
a6f6774 to
1c2f4ca
Compare
Member
Author
|
/azp run net - identity - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
christothes
approved these changes
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For sovereign cloud testing, many cloud-specific arm template parameters and environment variables get passed in from an external keyvault source. This makes them hard to manage and track. I plan to move these values into source control, and as a pre-requisite I am consolidating as many values into the arm template parameters as possible (as opposed to a mismash of parameters and env var declarations).