Add tests for new Copy/Update-LongTermRetentionBackup (fix reversion) #19246

xaliciayang · 2021-03-05T00:31:46Z

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

Please open PR in Draft mode if it is:
- Work in progress or not intended to be merged.
- Encountering multiple pipeline failures and working on fixes.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
I have read the contribution guidelines.
The pull request does not introduce breaking changes.

General Guidelines and Best Practices

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

SDK Generation Guidelines

The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

Include updated management metadata.
Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.
If the check fails at the Verify Code Generation step, please ensure:
- Do not modify any code in generated folders.
- Do not selectively include/remove generated files in the PR.
- Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
  Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version,

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

…Azure#19040)" (Azure#19205)" This reverts commit 85e2a5b.

allenjzhang · 2021-03-05T01:35:40Z

/azp run net - mgmt - ci

azure-pipelines · 2021-03-05T01:35:47Z

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

allenjzhang · 2021-03-05T07:12:11Z

/azp run net - mgmt - ci

azure-pipelines · 2021-03-05T07:12:22Z

Azure Pipelines successfully started running 1 pipeline(s).

m-nash · 2021-03-09T17:40:34Z

@xaliciayang CI is failing since it appears the generated code does not match what is checked in https://dev.azure.com/azure-sdk/public/_build/results?buildId=767998&view=logs&j=ca395085-040a-526b-2ce8-bdc85f692774&t=50b9345f-2a7f-5980-cb0f-1a8f9fb09dd0

check-enforcer · 2021-03-12T01:35:32Z

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps:

For data-plane/track 2 SDKs Issue the following command as a pull request comment:

/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run net - [service] - ci

For track 1 management-plane SDKs

Please open a separate PR and to your service SDK path in this file. Once that PR has been merged, you can re-run the pipeline to trigger the verification.

m-nash · 2021-03-12T17:48:39Z

/check-enforcer evaluate

markcowl · 2021-03-12T19:20:30Z

/azp run

azure-pipelines · 2021-03-12T19:20:35Z

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

markcowl · 2021-03-12T19:21:09Z

/azp run net - mgmt - ci

azure-pipelines · 2021-03-12T19:21:20Z

Azure Pipelines successfully started running 1 pipeline(s).

markcowl · 2021-03-12T19:21:41Z

/azp run net - core -ci

azure-pipelines · 2021-03-12T19:21:46Z

No pipelines are associated with this pull request.

xaliciayang · 2021-03-13T00:45:42Z

Azure/azure-rest-api-specs#12146

markcowl

AssemblyInfo.cs change is a simple update that needs to occur regardless.

There are some breaking changes in this PR, many of which could be mitigated with custom code. WIll need to decide for each whether to mitigate or seek approval from the breaking change board.

Can you please include a link to the swagger PR associated with these changes?

markcowl · 2021-03-13T00:34:37Z

sdk/sqlmanagement/Microsoft.Azure.Management.Sql/src/Generated/SqlManagementClient.cs

+        /// <summary>
+        /// Gets the ILongTermRetentionPoliciesOperations.
+        /// </summary>
+        public virtual ILongTermRetentionPoliciesOperations LongTermRetentionPolicies { get; private set; }


So, this is a breaking change, which would require a breaking change review. Why are we changing BackupLongTermRetentionPolicies to LongTermRetentionPolicies?

markcowl · 2021-03-13T00:35:52Z

...agement/Microsoft.Azure.Management.Sql/src/Generated/Models/TargetBackupStorageRedundancy.cs


    /// <summary>
-    /// Defines values for DatabaseState3.
+    /// Defines values for TargetBackupStorageRedundancy.


I think this is a breaking change as well. Although hard to tell from the diff.

markcowl · 2021-03-13T00:36:19Z

...sqlmanagement/Microsoft.Azure.Management.Sql/src/Generated/Models/LongTermRetentionPolicy.cs

    /// </summary>
    [Rest.Serialization.JsonTransformation]
-    public partial class BackupLongTermRetentionPolicy : ProxyResource
+    public partial class LongTermRetentionPolicy : ProxyResource


Breaking change that will require breakign change approval

markcowl · 2021-03-13T00:36:41Z

...gement/Microsoft.Azure.Management.Sql/src/Generated/Models/LongTermRetentionDatabaseState.cs

@@ -1,23 +0,0 @@
-// <auto-generated>


breaking change

markcowl · 2021-03-13T00:39:13Z

sdk/sqlmanagement/Microsoft.Azure.Management.Sql/src/Generated/Models/DatabaseUpdate.cs

        /// when the maintenance updates will occur.</param>
        /// <param name="tags">Resource tags.</param>
-        public DatabaseUpdate(Sku sku = default(Sku), string createMode = default(string), string collation = default(string), long? maxSizeBytes = default(long?), string sampleName = default(string), string elasticPoolId = default(string), string sourceDatabaseId = default(string), string status = default(string), System.Guid? databaseId = default(System.Guid?), System.DateTime? creationDate = default(System.DateTime?), string currentServiceObjectiveName = default(string), string requestedServiceObjectiveName = default(string), string defaultSecondaryLocation = default(string), string failoverGroupId = default(string), System.DateTime? restorePointInTime = default(System.DateTime?), System.DateTime? sourceDatabaseDeletionDate = default(System.DateTime?), string recoveryServicesRecoveryPointId = default(string), string longTermRetentionBackupResourceId = default(string), string recoverableDatabaseId = default(string), string restorableDroppedDatabaseId = default(string), string catalogCollation = default(string), bool? zoneRedundant = default(bool?), string licenseType = default(string), long? maxLogSizeBytes = default(long?), System.DateTime? earliestRestoreDate = default(System.DateTime?), string readScale = default(string), int? highAvailabilityReplicaCount = default(int?), string secondaryType = default(string), Sku currentSku = default(Sku), int? autoPauseDelay = default(int?), string storageAccountType = default(string), double? minCapacity = default(double?), System.DateTime? pausedDate = default(System.DateTime?), System.DateTime? resumedDate = default(System.DateTime?), string maintenanceConfigurationId = default(string), IDictionary<string, string> tags = default(IDictionary<string, string>))
+        public DatabaseUpdate(Sku sku = default(Sku), string createMode = default(string), string collation = default(string), long? maxSizeBytes = default(long?), string sampleName = default(string), string elasticPoolId = default(string), string sourceDatabaseId = default(string), string status = default(string), System.Guid? databaseId = default(System.Guid?), System.DateTime? creationDate = default(System.DateTime?), string currentServiceObjectiveName = default(string), string requestedServiceObjectiveName = default(string), string defaultSecondaryLocation = default(string), string failoverGroupId = default(string), System.DateTime? restorePointInTime = default(System.DateTime?), System.DateTime? sourceDatabaseDeletionDate = default(System.DateTime?), string recoveryServicesRecoveryPointId = default(string), string longTermRetentionBackupResourceId = default(string), string recoverableDatabaseId = default(string), string restorableDroppedDatabaseId = default(string), string catalogCollation = default(string), bool? zoneRedundant = default(bool?), string licenseType = default(string), long? maxLogSizeBytes = default(long?), System.DateTime? earliestRestoreDate = default(System.DateTime?), string readScale = default(string), int? highAvailabilityReplicaCount = default(int?), string secondaryType = default(string), Sku currentSku = default(Sku), int? autoPauseDelay = default(int?), string currentBackupStorageRedundancy = default(string), string requestedBackupStorageRedundancy = default(string), double? minCapacity = default(double?), System.DateTime? pausedDate = default(System.DateTime?), System.DateTime? resumedDate = default(System.DateTime?), string maintenanceConfigurationId = default(string), IDictionary<string, string> tags = default(IDictionary<string, string>))


Breaking change -any code that uses the storageAccountType parmeter, or any parameters beyond it will be broken.

the tests with this param were fixed and re-recorded in this PR

markcowl · 2021-03-13T00:40:02Z

sdk/sqlmanagement/Microsoft.Azure.Management.Sql/src/Generated/Models/DatabaseState5.cs

@@ -1,23 +0,0 @@
-// <auto-generated>


breakign change

markcowl · 2021-03-13T00:40:31Z

sdk/sqlmanagement/Microsoft.Azure.Management.Sql/src/Generated/Models/DatabaseState.cs

@@ -12,9 +12,9 @@ namespace Microsoft.Azure.Management.Sql.Models
 {

    /// <summary>
-    /// Defines values for DatabaseState1.


Removing DatabaseState1 is a breaking change

markcowl · 2021-03-13T00:41:09Z

sdk/sqlmanagement/Microsoft.Azure.Management.Sql/src/Generated/Models/Database.cs

-        /// <param name="storageAccountType">The storage account type used to
-        /// store backups for this database. Possible values include: 'GRS',
-        /// 'LRS', 'ZRS'</param>
+        /// <param name="currentBackupStorageRedundancy">The storage account


replacing storageAccountType with the two backupstorageredundancy parameters is a breaking change.

markcowl · 2021-03-13T00:41:37Z

...sqlmanagement/Microsoft.Azure.Management.Sql/src/Generated/Models/BackupStorageRedundancy.cs

@@ -12,12 +12,12 @@ namespace Microsoft.Azure.Management.Sql.Models
 {

    /// <summary>
-    /// Defines values for DatabaseState2.


removing DatabaseState2 is a breakign change (although a good one).

markcowl · 2021-03-13T00:44:55Z

sdk/sqlmanagement/Microsoft.Azure.Management.Sql/src/Microsoft.Azure.Management.Sql.csproj

 		<Description>Azure SQL Management SDK library</Description>
 		<AssemblyName>Microsoft.Azure.Management.Sql</AssemblyName>
-		<Version>1.49.0-preview</Version>
+		<Version>1.50.0-preview</Version>


You will also need to change the version in Properties\AssemblyInfo.cs

xaliciayang added 3 commits March 4, 2021 16:26

Revert "Revert "Add tests for new Copy/Update-LongTermRetentionBackup (…

0fad092

…Azure#19040)" (Azure#19205)" This reverts commit 85e2a5b.

use azure endpoint

6e732c9

skip test

fe4b5bf

xaliciayang requested review from YalinLi0312, allenjzhang, bquantump, m-nash, markcowl and nisha-bhatia as code owners March 5, 2021 00:31

openapi-assignment-bot bot assigned m-nash Mar 5, 2021

xaliciayang mentioned this pull request Mar 5, 2021

Use Azure Endpoints in session records (follow up #19040) #19184

Closed

11 tasks

xaliciayang added 2 commits March 9, 2021 13:53

updated sdk from swagger master

f13b239

update generate script

11de25e

xaliciayang force-pushed the fixReversionBsr branch from d525191 to 11de25e Compare March 10, 2021 01:41

xaliciayang added 6 commits March 9, 2021 17:42

update sql_resource-manager.txt

daae9f9

re-update Generated

cfa0920

regenerated clients, and updated AzSdk.RP.props

9c49837

updated sdk with version 2.0.4417

2f67e4a

re-generated again after autorest --reset

972326f

revert generate script and reinstate commit id into sql_resource-manager

dfda1ee

remove extra resource-manager.txt file

3f753aa

markcowl requested changes Mar 13, 2021

View reviewed changes

updated assembly info version

a466017

markcowl approved these changes Mar 13, 2021

View reviewed changes

markcowl merged commit 3a97c6f into Azure:master Mar 14, 2021

Add tests for new Copy/Update-LongTermRetentionBackup (fix reversion) #19246

Add tests for new Copy/Update-LongTermRetentionBackup (fix reversion) #19246

Uh oh!

Conversation

xaliciayang commented Mar 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

All SDK Contribution checklist:

Additional management plane SDK specific contribution checklist:

Management plane SDK Troubleshooting

Old outstanding PR cleanup

Uh oh!

allenjzhang commented Mar 5, 2021

Uh oh!

azure-pipelines bot commented Mar 5, 2021

Uh oh!

allenjzhang commented Mar 5, 2021

Uh oh!

azure-pipelines bot commented Mar 5, 2021

Uh oh!

m-nash commented Mar 9, 2021

Uh oh!

check-enforcer bot commented Mar 12, 2021

What is Check Enforcer?

Why am I getting this message?

What should I do now?

What if I am onboarding a new service?

For data-plane/track 2 SDKs Issue the following command as a pull request comment:

For track 1 management-plane SDKs

Uh oh!

m-nash commented Mar 12, 2021

Uh oh!

markcowl commented Mar 12, 2021

Uh oh!

azure-pipelines bot commented Mar 12, 2021

Uh oh!

markcowl commented Mar 12, 2021

Uh oh!

azure-pipelines bot commented Mar 12, 2021

Uh oh!

markcowl commented Mar 12, 2021

Uh oh!

azure-pipelines bot commented Mar 12, 2021

Uh oh!

xaliciayang commented Mar 13, 2021

Uh oh!

markcowl left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

xaliciayang commented Mar 5, 2021 •

edited

Loading