Authorization refresh fix #17609
Merged
Authorization refresh fix #17609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Member
Author
|
/azp run net - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jsquire
approved these changes
Dec 17, 2020
| string identifier) | ||
| { | ||
| string uri = endpoint.AbsoluteUri; | ||
| ServiceBusEventSource.Log.RequestAuthorizationStart(identifier, uri); |
Member
There was a problem hiding this comment.
This seems redundant to the existing AmqpLinkAuthorizationRefresh series (line 865). Am I overlooking something?
Member
Author
There was a problem hiding this comment.
The difference is that the refresh event is only logged on refreshes, whereas the new logs are written on every request (including the initial one). The new event is also verbose as opposed to Informational.
| } | ||
|
|
||
| [Event(RequestAuthorizationStartEvent, Level = EventLevel.Verbose, Message = "{0}: Requesting authorization to {1}")] | ||
| public virtual void RequestAuthorizationStart(string identifier, string endpoint) |
Member
There was a problem hiding this comment.
I may be overlooking, but I'm not sure from usage how these differ from the AmqpLinkAuthorizationRefresh series (ids 39-41). Should we consider merging them?
| # and the execution of the live tests. This allows RBAC to replicate and avoids flakiness in the first set | ||
| # of live tests that might otherwise start running before RBAC has replicated. | ||
|
|
||
| param ( |
Member
There was a problem hiding this comment.
Nice. I'm going to steal this after it merges...
annelo-msft
pushed a commit
to annelo-msft/azure-sdk-for-net
that referenced
this pull request
Feb 17, 2021
* save * Authorization refresh fix * Undo inadvertent changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.