Skip to content

[Event Hubs Client] Unblock Live Test Runs #17132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsquire merged 1 commit into from
Nov 21, 2020
Merged

[Event Hubs Client] Unblock Live Test Runs #17132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sdk/eventhub/Azure.Messaging.EventHubs.Processor/tests/Snippets/ReadMeSnippetsLiveTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ namespace Azure.Messaging.EventHubs.Tests.Snippets
/// </summary>
///
[TestFixture]
[Ignore("Debugging Potential Hang")]
[Category(TestCategory.Live)]
[Category(TestCategory.DisallowVisualStudioLiveUnitTesting)]
[SuppressMessage("Style", "IDE0059:Unnecessary assignment of a value", Justification = "Example assignments needed for snippet output content.")]
Expand Down
1 change: 1 addition & 0 deletions ...enthub/Azure.Messaging.EventHubs.Processor/tests/Snippets/Sample01_HelloWorldLiveTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ namespace Azure.Messaging.EventHubs.Tests.Snippets
/// </summary>
///
[TestFixture]
[Ignore("Debugging Potential Hang")]
[Category(TestCategory.Live)]
[Category(TestCategory.DisallowVisualStudioLiveUnitTesting)]
[SuppressMessage("Style", "IDE0059:Unnecessary assignment of a value", Justification = "Example assignments needed for snippet output content.")]
Expand Down
1 change: 1 addition & 0 deletions ...aging.EventHubs.Processor/tests/Snippets/Sample02_EventProcessorConfigurationLiveTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ namespace Azure.Messaging.EventHubs.Tests.Snippets
/// </summary>
///
[TestFixture]
[Ignore("Debugging Potential Hang")]
[Category(TestCategory.Live)]
[Category(TestCategory.DisallowVisualStudioLiveUnitTesting)]
[SuppressMessage("Style", "IDE0059:Unnecessary assignment of a value", Justification = "Example assignments needed for snippet output content.")]
Expand Down
1 change: 1 addition & 0 deletions ....Messaging.EventHubs.Processor/tests/Snippets/Sample03_EventProcessorHandlersLiveTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ namespace Azure.Messaging.EventHubs.Tests.Snippets
/// </summary>
///
[TestFixture]
[Ignore("Debugging Potential Hang")]
[Category(TestCategory.Live)]
[Category(TestCategory.DisallowVisualStudioLiveUnitTesting)]
[SuppressMessage("Style", "IDE0059:Unnecessary assignment of a value", Justification = "Example assignments needed for snippet output content.")]
Expand Down
1 change: 1 addition & 0 deletions .../Azure.Messaging.EventHubs.Processor/tests/Snippets/Sample04_ProcessingEventsLiveTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ namespace Azure.Messaging.EventHubs.Tests.Snippets
/// </summary>
///
[TestFixture]
[Ignore("Debugging Potential Hang")]
[Category(TestCategory.Live)]
[Category(TestCategory.DisallowVisualStudioLiveUnitTesting)]
[SuppressMessage("Style", "IDE0059:Unnecessary assignment of a value", Justification = "Example assignments needed for snippet output content.")]
Expand Down
1 change: 1 addition & 0 deletions ...ventHubs.Processor/tests/Snippets/Sample05_IdentityAndSharedAccessCredentialsLiveTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ namespace Azure.Messaging.EventHubs.Tests.Snippets
/// </summary>
///
[TestFixture]
[Ignore("Debugging Potential Hang")]
[Category(TestCategory.Live)]
[Category(TestCategory.DisallowVisualStudioLiveUnitTesting)]
[SuppressMessage("Style", "IDE0059:Unnecessary assignment of a value", Justification = "Example assignments needed for snippet output content.")]
Expand Down
1 change: 1 addition & 0 deletions ....EventHubs.Processor/tests/Snippets/Sample06_RequestingStorageServiceVersionsLiveTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ namespace Azure.Messaging.EventHubs.Tests.Snippets
/// </summary>
///
[TestFixture]
[Ignore("Debugging Potential Hang")]
[Category(TestCategory.Live)]
[Category(TestCategory.DisallowVisualStudioLiveUnitTesting)]
[SuppressMessage("Style", "IDE0059:Unnecessary assignment of a value", Justification = "Example assignments needed for snippet output content.")]
Expand Down
8 changes: 4 additions & 4 deletions sdk/eventhub/Azure.Messaging.EventHubs/tests/Consumer/EventHubConsumerClientLiveTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -895,16 +895,16 @@ public async Task ConsumerCannotReadWhenClosed()
var partition = (await consumer.GetPartitionIdsAsync(cancellationSource.Token)).First();
await SendEventsAsync(connectionString, sourceEvents, new CreateBatchOptions { PartitionId = partition }, cancellationSource.Token);

// Read the events and validate the resulting state.

// Create a local function that will close the consumer after five events have
// been read.
// been read. Because the close happens in the middle of iteration, allow for a short
// delay to ensure that the state transition has been fully captured.

async Task<bool> closeAfterRead(ReadState state)
{
if (state.Events.Count >= 2)
{
await consumer.CloseAsync(cancellationSource.Token).ConfigureAwait(false);
await consumer.CloseAsync(cancellationSource.Token);
await Task.Delay(250);
Copy link
Member

@christothes christothes Nov 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious - Is an actual delay necessary here, or is a Task.Yeild() enough?

Copy link
Member Author

@jsquire jsquire Nov 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would imagine that yielding would be enough, since we just want to ensure that the state updates, but I always seem to forget that exists and Delay(0) just reads weird to me. I'll take a note to revisit, but will probably avoid pushing up changes if the live suite passes this way so that I can unblock tomorrow's run.

}

return true;
Expand Down
6 changes: 4 additions & 2 deletions sdk/eventhub/Azure.Messaging.EventHubs/tests/Primitives/PartitionReceiverLiveTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -874,13 +874,15 @@ public async Task ReceiverCannotReadWhenClosed()
await using (var receiver = new PartitionReceiver(EventHubConsumerClient.DefaultConsumerGroupName, partition, EventPosition.Earliest, connectionString))
{
// Create a local function that will close the receiver after five events have
// been read.
// been read. Because the close happens during the read loop, allow for a short
// delay to ensure that the state transition has been fully captured.

async Task<bool> closeAfterFiveRead(ReadState state)
{
if (state.Events.Count >= 2)
{
await receiver.CloseAsync(cancellationSource.Token).ConfigureAwait(false);
await receiver.CloseAsync(cancellationSource.Token);
await Task.Delay(250);
}

return true;
Expand Down
1 change: 1 addition & 0 deletions sdk/eventhub/Azure.Messaging.EventHubs/tests/Snippets/ReadMeSnippetsLiveTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ namespace Azure.Messaging.EventHubs.Tests.Snippets
/// </summary>
///
[TestFixture]
[Ignore("Debugging Potential Hang")]
[Category(TestCategory.Live)]
[Category(TestCategory.DisallowVisualStudioLiveUnitTesting)]
[SuppressMessage("Style", "IDE0059:Unnecessary assignment of a value", Justification = "Example assignments needed for snippet output content.")]
Expand Down
1 change: 1 addition & 0 deletions sdk/eventhub/Azure.Messaging.EventHubs/tests/Snippets/Sample01_HelloWorldLiveTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ namespace Azure.Messaging.EventHubs.Tests.Snippets
/// </summary>
///
[TestFixture]
[Ignore("Debugging Potential Hang")]
[Category(TestCategory.Live)]
[Category(TestCategory.DisallowVisualStudioLiveUnitTesting)]
[SuppressMessage("Style", "IDE0059:Unnecessary assignment of a value", Justification = "Example assignments needed for snippet output content.")]
Expand Down
1 change: 1 addition & 0 deletions sdk/eventhub/Azure.Messaging.EventHubs/tests/Snippets/Sample02_EventHubsClientsLiveTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ namespace Azure.Messaging.EventHubs.Tests.Snippets
/// </summary>
///
[TestFixture]
[Ignore("Debugging Potential Hang")]
[Category(TestCategory.Live)]
[Category(TestCategory.DisallowVisualStudioLiveUnitTesting)]
[SuppressMessage("Style", "IDE0059:Unnecessary assignment of a value", Justification = "Example assignments needed for snippet output content.")]
Expand Down
1 change: 1 addition & 0 deletions sdk/eventhub/Azure.Messaging.EventHubs/tests/Snippets/Sample03_EventHubMetadataLiveTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ namespace Azure.Messaging.EventHubs.Tests.Snippets
/// </summary>
///
[TestFixture]
[Ignore("Debugging Potential Hang")]
[Category(TestCategory.Live)]
[Category(TestCategory.DisallowVisualStudioLiveUnitTesting)]
[SuppressMessage("Style", "IDE0059:Unnecessary assignment of a value", Justification = "Example assignments needed for snippet output content.")]
Expand Down
1 change: 1 addition & 0 deletions sdk/eventhub/Azure.Messaging.EventHubs/tests/Snippets/Sample04_PublishingEventsLiveTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ namespace Azure.Messaging.EventHubs.Tests.Snippets
/// </summary>
///
[TestFixture]
[Ignore("Debugging Potential Hang")]
[Category(TestCategory.Live)]
[Category(TestCategory.DisallowVisualStudioLiveUnitTesting)]
[SuppressMessage("Style", "IDE0059:Unnecessary assignment of a value", Justification = "Example assignments needed for snippet output content.")]
Expand Down
1 change: 1 addition & 0 deletions sdk/eventhub/Azure.Messaging.EventHubs/tests/Snippets/Sample05_ReadingEventsLiveTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ namespace Azure.Messaging.EventHubs.Tests.Snippets
/// </summary>
///
[TestFixture]
[Ignore("Debugging Potential Hang")]
[Category(TestCategory.Live)]
[Category(TestCategory.DisallowVisualStudioLiveUnitTesting)]
[SuppressMessage("Style", "IDE0059:Unnecessary assignment of a value", Justification = "Example assignments needed for snippet output content.")]
Expand Down
1 change: 1 addition & 0 deletions ...essaging.EventHubs/tests/Snippets/Sample06_IdentityAndSharedAccessCredentialsLiveTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ namespace Azure.Messaging.EventHubs.Tests.Snippets
/// </summary>
///
[TestFixture]
[Ignore("Debugging Potential Hang")]
[Category(TestCategory.Live)]
[Category(TestCategory.DisallowVisualStudioLiveUnitTesting)]
[SuppressMessage("Style", "IDE0059:Unnecessary assignment of a value", Justification = "Example assignments needed for snippet output content.")]
Expand Down
1 change: 1 addition & 0 deletions ...hub/Azure.Messaging.EventHubs/tests/Snippets/Sample07_EarlierLanguageVersionsLiveTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ namespace Azure.Messaging.EventHubs.Tests.Snippets
/// </summary>
///
[TestFixture]
[Ignore("Debugging Potential Hang")]
[Category(TestCategory.Live)]
[Category(TestCategory.DisallowVisualStudioLiveUnitTesting)]
[SuppressMessage("Style", "IDE0059:Unnecessary assignment of a value", Justification = "Example assignments needed for snippet output content.")]
Expand Down
2 changes: 1 addition & 1 deletion sdk/eventhub/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ trigger: none
extends:
template: ../../eng/pipelines/templates/stages/archetype-sdk-tests.yml
parameters:
MaxParallel: 1
MaxParallel: 6
ServiceDirectory: eventhub
TimeoutInMinutes: 130
Clouds: 'Public,Canary'