Skip to content

[KeyVault] Regen with "package-preview-2020-04" #15445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
YalinLi0312 merged 2 commits into from
Oct 5, 2020
Merged

[KeyVault] Regen with "package-preview-2020-04" #15445

YalinLi0312 merged 2 commits into from
Oct 5, 2020

Conversation

@isra-fel
Copy link
Member

@isra-fel isra-fel commented Sep 25, 2020

Merged swagger PR: Azure/azure-rest-api-specs#10872 (FYI @riteshchitlangia1 )

Thanks

@ghost ghost added the KeyVault label Sep 25, 2020
isra-fel
isra-fel commented Sep 25, 2020
View reviewed changes
sdk/keyvault/Microsoft.Azure.Management.KeyVault/src/Microsoft.Azure.Management.KeyVault.csproj
<PackageTags>Microsoft Azure key vault management;Key Vault;</PackageTags>
<PackageReleaseNotes>
<![CDATA[
- Support CRUD operations to managed HSM
Copy link
Member Author

@isra-fel isra-fel Sep 25, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't remove release notes from last release because I want to keep it until next stable release 3.1.0

YalinLi0312
YalinLi0312 suggested changes Sep 25, 2020
View reviewed changes
Copy link

@YalinLi0312 YalinLi0312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update versions in AssemblyInfo.cs?

@YalinLi0312 YalinLi0312 added Mgmt This issue is related to a management package. track1 labels Sep 25, 2020
@isra-fel
Copy link
Member Author

isra-fel commented Sep 27, 2020

Hi @YalinLi0312 I just changed the revision part of the version 3.1.0-preview.1 -> 3.1.0-preview.2. Assembly version is already 3.1.0.0, so there's no need to change.

Thanks

@YalinLi0312
Copy link

YalinLi0312 commented Sep 29, 2020

Hi @YalinLi0312 I just changed the revision part of the version 3.1.0-preview.1 -> 3.1.0-preview.2. Assembly version is already 3.1.0.0, so there's no need to change.

Thanks

What I found is AssemblyVersion("3.0.0.0") in master: https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/keyvault/Microsoft.Azure.Management.KeyVault/src/Properties/AssemblyInfo.cs#L12

@isra-fel
Copy link
Member Author

isra-fel commented Sep 29, 2020

Ah good catch! Thank you very much :)

@YalinLi0312 YalinLi0312 merged commit 82fc1bb into Azure:master Oct 5, 2020
@isra-fel isra-fel deleted the kv-name-validation branch October 7, 2020 01:56
annelo-msft pushed a commit to annelo-msft/azure-sdk-for-net that referenced this pull request Feb 17, 2021
@isra-fel @annelo-msft
[KeyVault] Regen with "package-preview-2020-04" (Azure#15445)
2afc743
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@YalinLi0312 YalinLi0312 YalinLi0312 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@YalinLi0312 YalinLi0312

Labels

KeyVault Mgmt This issue is related to a management package.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@isra-fel @YalinLi0312