Update Cosmos DB SDK to 06-01-preview #15220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Meha Kaushik <[email protected]>
kristynhamasaki
requested review from
YalinLi0312,
allenjzhang,
bquantump,
m-nash,
markcowl and
nisha-bhatia
as code owners
allenjzhang
suggested changes
Sep 23, 2020
Contributor
There was a problem hiding this comment.
Could you:
- Check in the metadata TXT file generated when you run
generate.ps1(details)
Everything else looks good. Thanks
nichatur
suggested changes
Sep 24, 2020
...mosdb/Microsoft.Azure.Management.CosmosDB/tests/ScenarioTests/SqlResourcesOperationsTests.cs
Outdated
Show resolved
Hide resolved
...mosdb/Microsoft.Azure.Management.CosmosDB/tests/ScenarioTests/SqlResourcesOperationsTests.cs
Show resolved
Hide resolved
...mosdb/Microsoft.Azure.Management.CosmosDB/tests/ScenarioTests/SqlResourcesOperationsTests.cs
Show resolved
Hide resolved
...mosdb/Microsoft.Azure.Management.CosmosDB/tests/ScenarioTests/SqlResourcesOperationsTests.cs
Show resolved
Hide resolved
...mosdb/Microsoft.Azure.Management.CosmosDB/tests/ScenarioTests/SqlResourcesOperationsTests.cs
Show resolved
Hide resolved
Contributor
Author
|
@nichatur Thank you for your suggestions. I have updated the tests. Please review, thanks! |
nichatur
approved these changes
Sep 25, 2020
...mosdb/Microsoft.Azure.Management.CosmosDB/tests/ScenarioTests/SqlResourcesOperationsTests.cs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Hi @allenjzhang I have updated the metadata txt file. Thank you! |
allenjzhang
suggested changes
Sep 25, 2020
sdk/cosmosdb/Microsoft.Azure.Management.CosmosDB/src/Microsoft.Azure.Management.CosmosDB.csproj
Show resolved
Hide resolved
allenjzhang
approved these changes
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Cosmos DB SDK from 2020-04-01 to 2020-06-01-preview
This change includes added Sql RBAC operations + test coverage