Skip to content

Fix bug when sanitizing empty body #14885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoshLove-msft merged 4 commits into from
Sep 4, 2020
Merged

Fix bug when sanitizing empty body #14885

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
29a8846
Fix bug when sanitizing empty body
JoshLove-msft Sep 4, 2020
95baea5
Filter based on request method; add test
JoshLove-msft Sep 4, 2020
ed97828
param name
JoshLove-msft Sep 4, 2020
cc24715
Split tests
JoshLove-msft Sep 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion sdk/core/Azure.Core.TestFramework/src/RecordedTestSanitizer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,10 @@ public virtual void Sanitize(RecordEntry entry)

SanitizeHeaders(entry.Response.Headers);

SanitizeBody(entry.Response);
if (entry.RequestMethod != RequestMethod.Head)
{
SanitizeBody(entry.Response);
}
}

public virtual void Sanitize(RecordSession session)
Expand Down
33 changes: 33 additions & 0 deletions sdk/core/Azure.Core/tests/RecordSessionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,6 +409,39 @@ public void RecordSessionLookupSkipsRequestBodyWhenFilterIsOn()
Assert.Throws<TestRecordingMismatchException>(() => playbackTransport.Process(message));
}

[Test]
[TestCase(true)]
[TestCase(false)]
public void ContentLengthUpdatedCorrectlyOnEmptyBody(bool isHeadRequest)
{
var sanitizer = new RecordedTestSanitizer();
var entry = new RecordEntry()
{
RequestUri = "http://localhost/",
RequestMethod = isHeadRequest ? RequestMethod.Head : RequestMethod.Get,
Response =
{
Headers =
{
{"Content-Length", new[] {"41"}},
{"Some-Header", new[] {"Random value"}},
{"Some-Other-Header", new[] {"V"}}
},
Body = new byte[0]
}
};
sanitizer.Sanitize(entry);

if (isHeadRequest)
{
Assert.AreEqual(new[] { "41" }, entry.Response.Headers["Content-Length"]);
}
else
{
Assert.AreEqual(new[] { "0" }, entry.Response.Headers["Content-Length"]);
}
}

private class TestSanitizer : RecordedTestSanitizer
{
public override string SanitizeVariable(string variableName, string environmentVariableValue)
Expand Down