-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Add remaining test cases from track one DNS SDK to track two #14766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
b2a4f14
WIP: Initial CRUD and List test for record and zone
bquantump 38b9eb1
WIP: Port of cloud issues
bquantump e15afb3
WIP: OneTimeTearDown and setup working. No double test runs
bquantump 4c799eb
WIP: don't make zone twice
bquantump 3f88fd3
WIP: Commit test
90204f1
WIP: Fix changelog and readme
bquantump ce4d0de
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-net
bquantump 6fee9cf
WIP: Fix yaml
bquantump 66d2634
WIP: Fix yml 2
bquantump a92d37c
WIP: Remove unused function
bquantump c0abf80
Remove .swp file
bquantump 8fed2c7
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-net
bquantump f34768b
Remove SWP file
bquantump 040df84
Update DNS Track 2 test
bquantump f28d520
Add Tests Recordings
bquantump 936583d
Fix Class name
bquantump 6cf295d
WIP: Update tests
bquantump 212e5c4
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-net
bquantump 88c43bf
WIP: Make exception test clearner
bquantump a3e2c57
WIP: Update live test records
bquantump 5cf8665
Revert json change
bquantump 556c220
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-net
bquantump File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
1 change: 1 addition & 0 deletions
1
sdk/dns/Azure.ResourceManager.Dns/tests/Azure.ResourceManager.Dns.Tests.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,25 +22,20 @@ public static bool AreEqualPrereq( | |
| Azure.ResourceManager.Dns.Models.Resource second, | ||
| bool ignoreEtag = false) | ||
| { | ||
| if (first == null && second == null) | ||
| { | ||
| return true; | ||
| } | ||
| else if (first == null || second == null) | ||
|
|
||
| if (first == null || second == null) | ||
| { | ||
| return false; | ||
| } | ||
|
|
||
| if (first.Location != second.Location | ||
| || first.Name != second.Name) | ||
| if (first.Location.ToLower() != second.Location.ToLower()) | ||
| { | ||
| return false; | ||
| } | ||
|
|
||
| if (first.Tags != null || second.Tags != null) | ||
| if (first.Tags != null && second.Tags != null) | ||
| { | ||
| if (first.Tags == null || second.Tags == null || | ||
| first.Tags.Count != second.Tags.Count) | ||
| if (first.Tags.Count != second.Tags.Count) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: if you ever need to compare content of Tags collection, LINQ's Intersect, Except are useful. |
||
| { | ||
| return false; | ||
| } | ||
|
|
@@ -54,6 +49,9 @@ public static bool AreEqualPrereq( | |
| } | ||
| } | ||
| } | ||
| else{ | ||
| return false; | ||
| } | ||
|
|
||
| return true; | ||
| } | ||
|
|
||
165 changes: 0 additions & 165 deletions
165
...ResourceManager.Dns/tests/SessionRecords/ScenarioTests/DnsCreateARecordDelete()Async.json
This file was deleted.
Oops, something went wrong.
113 changes: 0 additions & 113 deletions
113
...anager.Dns/tests/SessionRecords/ScenarioTests/DnsRecordSetListByResourceGroup()Async.json
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: String.Compare() is preferred over ==/!=