Merge release/keyvault-4.1.0 into master #14193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add support for and change latest version to use 7.1 * Add RecoverableDays to properties and import to KeyOperations * Update public APIs * Re-record tests for Key Vault 7.1
We released a couple servicing versions after shipping 4.1.0-preview.1, so it made the new 4.1.0 CHANGELOG entries look really lightweight.
heaths
requested review from
KrzysztofCwalina,
pakrym and
tg-msft
as code owners
ghost
added
the
Remove @isra-fel and @erich-wang from mangement plane code owners
…pe" (Azure#13936) * Metadata Operation Type * generated * Update cognitiveservices_data-plane_QnAMaker.txt folder stucture * Changelog csproj version changes
* Anomaly Detector new release * update version * update the changelog * update changelog * Update release date * update CHANGELOG.md * update CHANGELOG.md * Change release date Co-authored-by: Alexander Sher <[email protected]>
Co-authored-by: Harvey Chen <[email protected]> Co-authored-by: Youri <[email protected]>
Co-authored-by: Harvey Chen <[email protected]>
Co-authored-by: Youri <[email protected]> Co-authored-by: Harvey Chen <[email protected]>
* Update Autorest C# - network * Update Network Test Record Update Network Test Record * regen * Export api Co-authored-by: Harvey Chen <[email protected]>
christothes
reviewed
Aug 13, 2020
sdk/keyvault/Azure.Security.KeyVault.Keys/src/Cryptography/CryptographyClientOptions.cs
Outdated
Show resolved
Hide resolved
christothes
approved these changes
Aug 13, 2020
Member
christothes
left a comment
christothes
left a comment
There was a problem hiding this comment.
Looks good, with the exception of the They/The typo.
* Use ConcurrentBag when testing progress reports * Fixed check in progress tests. Progress tests now check max value of reports, instead of last, now that their grouping is unordered. * Fix 0-element list race condition. Sometimes Progress<T> fails to report anything before we start checking the collection of its outputs, which causes IEnumerable<T>::Max() to throw. Added safety for this check.
heaths
requested review from
AlexGhiondea,
AlexanderSher,
MS-syh2qs,
Sandido,
allenjzhang,
amishra-dev,
amnguye,
annelo-msft,
azabbasi,
barustum,
bikamani,
chidozieononiwu,
danieljurek,
dkulkarni-ms,
drwill-ms,
grizzlytheodore,
haagha,
jsquire,
kasobol-msft,
kinelski,
madewithsmiles,
mitchdenny,
prmathur-microsoft,
seanmcc-msft,
serkantkaraca,
timtay-microsoft and
vinagesh
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needed a separate merge commit since there were lots of conflicts expected, and re-recordings were needed.