Reading TTL as the difference between absoluteexpirytime and creationtime #12225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…time. ttl field in the message header is of type unsigned integer, so it cannot support TTL values larger than 50 days when converted to milliseconds.
nemakam
approved these changes
May 26, 2020
| if (sbMessage.TimeToLive != TimeSpan.MaxValue) | ||
| { | ||
| amqpMessage.Header.Ttl = (uint)sbMessage.TimeToLive.TotalMilliseconds; | ||
| amqpMessage.Header.Ttl = sbMessage.TimeToLive.TotalMilliseconds < UInt32.MaxValue ? (uint)sbMessage.TimeToLive.TotalMilliseconds : UInt32.MaxValue; |
Member
There was a problem hiding this comment.
We should considering adding this validation into the property for Track 2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TTL field in the message header is of type unsigned integer, so it cannot support TTL values
larger than 50 days when converted to milliseconds. So reading TTL as the difference between AbsoluteExpiryTime and CreationTime properties on the AMQP message.