Skip to content

EventHub: updated Package and added new test BYOK and Clusters #11949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
isra-fel merged 7 commits into from
May 12, 2020
Merged

EventHub: updated Package and added new test BYOK and Clusters #11949

isra-fel merged 7 commits into from
May 12, 2020

Conversation

@v-Ajnava
Copy link

@v-Ajnava v-Ajnava commented May 8, 2020 •
edited
Loading

isra-fel
isra-fel suggested changes May 9, 2020
View reviewed changes
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, we updated our folder structure quite log ago. Every project should be in /sdk. Please remove src/SDKs and everything in it.

Besides, please generate your sdk using this script sdk/eventhub/Microsoft.Azure.Management.EventHub/src/generate.ps1. It should also generate a metadata file in /eng/mgmt/mgmtmetada please also check it in.

Thanks

@isra-fel isra-fel added Mgmt This issue is related to a management package. needs-revision labels May 9, 2020
@v-Ajnava v-Ajnava assigned isra-fel and unassigned v-Ajnava May 11, 2020
isra-fel
isra-fel suggested changes May 11, 2020
View reviewed changes
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @v-Ajnava please

  • Add a link to the openapi spec review PR here
  • Update release notes in csproj
  • Update versions in csproj and assemblyinfo.cs if you are going to release

Thanks

@v-Ajnava
Copy link
Author

v-Ajnava commented May 12, 2020

@isra-fel, added all swagger PRs regarding changes, added release notes and updated version. please review and let me know if any changes needed

isra-fel
isra-fel approved these changes May 12, 2020
View reviewed changes
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@isra-fel isra-fel merged commit 216994e into Azure:master May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erich-wang erich-wang Awaiting requested review from erich-wang

1 more reviewer

@isra-fel isra-fel isra-fel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@isra-fel isra-fel

@v-Ajnava v-Ajnava

Labels

Mgmt This issue is related to a management package.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@v-Ajnava @isra-fel