Skip to content

Conversation

@HaoQian-MS
Copy link
Contributor

@HaoQian-MS HaoQian-MS commented Mar 25, 2020

@isra-fel isra-fel self-assigned this Mar 26, 2020
@isra-fel isra-fel added needs-review Mgmt This issue is related to a management package. labels Mar 26, 2020
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @HaoQian-MS , could you

  • Add a link to the swagger spec review PR in the description
  • Include the .txt file generated when you run generate.ps1(details)
    • If the file wasn't updated, please edit generate.ps1 to replace "latest" to "2.0.4413" and try again
  • Update api tag in AzSdk.RP.props, release notes in csproj
  • Update versions in csproj and assemblyinfo.cs if you are going to release

Thanks

@HaoQian-MS HaoQian-MS requested a review from isra-fel March 27, 2020 08:50
@HaoQian-MS
Copy link
Contributor Author

Txt uploaded.
No changes in tag. Release notes included in changelog.
No intension to update version.

@isra-fel isra-fel self-assigned this Mar 30, 2020
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isra-fel isra-fel merged commit a9a4c6c into Azure:master Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management package.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants