[Storage][DataLake] Updated ErrorExtensions

[seanmcc-msft]

#8235

• Make ErrorExtensions.CreateException() and extension method on Response instead of string
• "Can you check the response for an x-ms-error-code header? It feels weird to use the status here because that's not how it's documented in the REST API. I almost think I'd prefer null for clarity." -Ted
• "We haven't been using the higher level Deserialize/Serialize methods for both perf and portability (they require a library that conflicts with something in Azure Functions' default env). We should file a work item on this. Take a look at KeyVault or AppConfig for examples of how they parse their models without Deserialize." -Ted

[seanmcc-msft]

@tg-msft, I don't know if we can actually do this. The ErrorExtensions class is tightly coupled with the auto-generated DataLakeRestClient.

[tg-msft]

Ah, so this was us changing the swagger and now the model type is effectively a string? That makes sense for the first bullet.

I think the second and third bullets are still valid.

[seanmcc-msft]

@tg-msft, can you point me to a specific instance of KeyVault or AppConfig avoiding using the Deserialize/Serialize methods? I'm not familiar with the structure of those SDKs, so I'm not sure where to look.

[tg-msft]

Here's an example from AppConfig: https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/appconfiguration/Azure.Data.AppConfiguration/src/ConfigurationServiceSerializer.cs

[JimSuplizio]

Hi @seanmcc-msft, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.