Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future proof Tables expression parser #19901

Closed
christothes opened this issue Mar 29, 2021 · 1 comment
Closed

Future proof Tables expression parser #19901

christothes opened this issue Mar 29, 2021 · 1 comment
Labels
Client This issue points to a problem in the data-plane of the library. Tables

Comments

@christothes
Copy link
Member

According to dotnet/runtime#47231 , we may need to do some work to future proof our expression parser implementation in Tables.

Although we do not implement IQueryable directly, we're still using reflection and comparing against argument count in a couple of places like here though. Might be worth being more explicit or adding unit tests in case someone ever puts new overloads in .NET Core vNextNextNext.

@christothes christothes added Client This issue points to a problem in the data-plane of the library. Tables labels Mar 29, 2021
@pallavit
Copy link
Contributor

@christothes do you still see value in making this change?

@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Tables
Projects
None yet
Development

No branches or pull requests

2 participants