Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Title is incorrect "Azure SDK for NET APIs" and inconsistent with official branding #18596

Closed
IEvangelist opened this issue Feb 9, 2021 · 3 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Docs EngSys This issue is impacting the engineering system.

Comments

@IEvangelist
Copy link
Member

Describe the bug
On the https://azure.github.io/azure-sdk-for-net/ site, the title and top-level breadcrumb are incorrectly named. Instead of "Azure SDK for NET APIs", is should read "Azure SDK for .NET APIs". This is very important for our consistency in branding .NET. I'm assuming that this issue is somewhat related to this docfx generation script here.

Expected behavior
The site title and breadcrumb should be "Azure SDK for .NET APIs"

Actual behavior (include Exception or Stack Trace)
The site title and breadcrumb actually say "Azure SDK for NET APIs"

To Reproduce

1.Visit https://azure.github.io/azure-sdk-for-net/ and observe

image

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Feb 9, 2021
@jsquire jsquire added Client This issue points to a problem in the data-plane of the library. Docs EngSys This issue is impacting the engineering system. labels Feb 9, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Feb 9, 2021
@jsquire
Copy link
Member

jsquire commented Feb 9, 2021

Hi @IEvangelist. Thanks for bringing this to our attention. I've tagged and routed to the person best able to address this.

@sima-zhu
Copy link
Contributor

sima-zhu commented Feb 9, 2021

Here is the PR for fix.
#18623

@weshaggard weshaggard assigned sima-zhu and unassigned AlexGhiondea Feb 9, 2021
@sima-zhu
Copy link
Contributor

Issue got fixed.
https://azure.github.io/azure-sdk-for-net/

Thanks for reporting the issue. Closed the issue for now. Feel free to reopen if anything unaddressed.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Docs EngSys This issue is impacting the engineering system.
Projects
None yet
Development

No branches or pull requests

4 participants