Address arch board feedback for Opinion Mining design

[maririos]

• Remove [EditorBrowsable(EditorBrowsableState.Never)] from single method AnalyzeSentiment(string document, string language) and AnalyzeSentimentAsync(string document, string language)
• Consider making IncludeOpinionMining an enum flag like https://apiview.dev/Assemblies/Review/a17b6175b93847db83a99c7fcfeca9ab#Azure.Storage.Blobs.Models.BlobStates.
• Consider renaming MinedOpinion to MinedOpinions -> that way you know you are going to get opinions (English)
• Hide public static SentenceSentiment SentenceSentiment(TextSentiment sentiment, string text, double positiveScore, double neutralScore, double negativeScore); in TextAnalyticsModelFactory

[maririos]

Consider renaming MinedOpinion to MinedOpinions -> that way you know you are going to get opinions (English)

V-team talked about this and decided to leave as is. The reason, if renamed, it will look like:

SentenceSentiment:
  Text
  Sentiment
  ...
  List<MinedOpinions> MinedOpinions

Both object and property plural might confuse the user into what the difference is, and because of that we decided not to rename

[maririos]

Consider making IncludeOpinionMining an enum flag like

I took a look at how other libraries in .NET manage this, read the documentation, and asked the service if we could have multiple analysis executed in a single document. i.e. apply opinion mining, and emotion based analysis into this doc.
Answer is yes.

Here is a proposal for .NET API View

Before the change:

await client.AnalyzeSentimentAsync(document, options: new AnalyzeSentimentOptions() { IncludeOpinionMining = true });

After the proposed change:

await client.AnalyzeSentimentAsync(document, options: new AnalyzeSentimentOptions() { IncludeAnalysis = AnalyzeSentimentType.OpinionMining });

I do like this proposal as it will allow .NET users to do something like

IncludeAnalysis = AnalyzeSentimentType.OpinionMining | AnalyzeSentimentType.EmotionBased

which means apply those 2 types of analysis for the same document, in the same call