Skip to content

Commit c378412

Browse files
committed
Resolve feedback
1 parent b69cea6 commit c378412

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

sdk/keyvault/Azure.Security.KeyVault.Secrets/MigrationGuide.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ Familiarity with the `Microsoft.Azure.KeyVault` library is assumed. For those ne
1515
- [Getting secrets](#getting-secrets)
1616
- [Listing secrets](#listing-secrets)
1717
- [Deleting secrets](#deleting-secrets)
18+
- [Managing shared access signatures](#managing-shared-access-signatures)
1819
- [Additional samples](#additional-samples)
1920

2021
## Migration benefits
@@ -27,8 +28,6 @@ To try and improve the development experience across Azure services, including K
2728

2829
The new Key Vault secrets library `Azure.Security.KeyVault.Secrets` provides the ability to share in some of the cross-service improvements made to the Azure development experience, such as using the new `Azure.Identity` library to share a single authentication between clients and a unified diagnostics pipeline offering a common view of the activities across each of the client libraries.
2930

30-
While we believe that there is significant benefit to adopting the new Key Vault secrets library `Azure.Security.KeyVault.Secrets`, it is important to be aware that the previous version `Microsoft.Azure.KeyVault` has not been officially deprecated. It will continue to be supported with security and critical bug fixes. However, it is not under active development and will eventually be deprecated.
31-
3231
## General changes
3332

3433
### Package and namespaces
@@ -45,8 +44,6 @@ In the interest of simplifying the API we've split `KeyVaultClient` into separat
4544
- `Azure.Security.KeyVault.Keys` contains `KeyClient` for key management operations and `CryptographyClient` for cryptographic operations.
4645
- `Azure.Security.KeyVault.Secrets` contains `SecretClient` for secret management operations.
4746

48-
Because [Role-Based Access Control (RBAC)](https://docs.microsoft.com/azure/role-based-access-control/overview) is recommended, we did not implement APIs for Key Vault-managed storage accounts. See [our sample](https://docs.microsoft.com/samples/azure/azure-sdk-for-net/share-link/) for source you can copy into your project if you require managing [Shared Access Signature (SAS)](https://docs.microsoft.com/azure/storage/common/storage-sas-overview) tokens in your application and cannot use RBAC.
49-
5047
These clients also share a single connection pool by default despite being separated, resolving an issue with the old `KeyVaultClient` that created a new connection pool with each new instance and could exhaust socket connections.
5148

5249
### Client constructors
@@ -245,6 +242,10 @@ if (deleteOperation.Value.RecoveryId != null)
245242

246243
Synchronous methods are also available on `SecretClient`, though we recommend you use asynchronous methods throughout your projects when possible for better performing applications.
247244

245+
### Managing shared access signatures
246+
247+
Because [Role-Based Access Control (RBAC)](https://docs.microsoft.com/azure/role-based-access-control/overview) is now recommended for storage account access control, the APIs for Key Vault-managed storage accounts are no longer available in version 4 of Key Vault client libraries. If you cannot use RBAC and must use [Shared Access Signatures (SAS)](https://docs.microsoft.com/azure/storage/common/storage-sas-overview), see [our sample](https://docs.microsoft.com/samples/azure/azure-sdk-for-net/share-link/) for source you can use in your own projects built on the same `Azure.Core` pipeline as the version 4 client libraries described above.
248+
248249
## Additional samples
249250

250251
- [Key Vault secrets samples for .NET](https://docs.microsoft.com/samples/azure/azure-sdk-for-net/azuresecuritykeyvaultsecrets-samples/)

0 commit comments

Comments
 (0)