[Event Hubs Client] Misc. Formatting and Test Tweaks (#11648)

The focus of these changes is to make a miscellaneous set of small tweaks and
fixes, largely focused on formatting and tests.

Author: jsquire

sdk/eventhub/Azure.Messaging.EventHubs.Processor/tests/CheckpointStore/BlobsCheckpointStoreLiveTests.cs

@@ -10,7 +10,6 @@
 using Azure.Messaging.EventHubs.Primitives;
 using Azure.Messaging.EventHubs.Tests;
 using Azure.Storage.Blobs;
-using Moq;
 using NUnit.Framework;
 
 namespace Azure.Messaging.EventHubs.Processor.Tests

sdk/eventhub/Azure.Messaging.EventHubs.Processor/tests/CheckpointStore/BlobsCheckpointStoreTests.cs

@@ -11,6 +11,7 @@
 using Azure.Messaging.EventHubs.Core;
 using Azure.Messaging.EventHubs.Primitives;
 using Azure.Messaging.EventHubs.Processor.Diagnostics;
+using Azure.Messaging.EventHubs.Tests;
 using Azure.Storage;
 using Azure.Storage.Blobs;
 using Azure.Storage.Blobs.Models;
@@ -119,7 +120,6 @@ public void ListOwnershipLogsErrorOnException()
             target.Logger = mockLog.Object;
 
             Assert.That(async () => await target.ListOwnershipAsync(FullyQualifiedNamespace, EventHubName, ConsumerGroup, new CancellationToken()), Throws.InstanceOf<RequestFailedException>());
-
             mockLog.Verify(m => m.ListOwnershipError(FullyQualifiedNamespace, EventHubName, ConsumerGroup, ex.Message));
         }
 

sdk/eventhub/Azure.Messaging.EventHubs.Processor/tests/Diagnostics/DiagnosticsTests.cs

@@ -44,7 +44,7 @@ public class DiagnosticsTests
         public async Task UpdateCheckpointAsyncCreatesScope()
         {
             using var cancellationSource = new CancellationTokenSource();
-            cancellationSource.CancelAfter(TimeSpan.FromSeconds(15));
+            cancellationSource.CancelAfter(TimeSpan.FromSeconds(30));
 
             var completionSource = new TaskCompletionSource<bool>(TaskCreationOptions.RunContinuationsAsynchronously);
             var mockContext = new Mock<PartitionContext>("65");

sdk/eventhub/Azure.Messaging.EventHubs.Processor/tests/Infrastructure/StorageTestEnvironment.cs

@@ -15,22 +15,21 @@ namespace Azure.Messaging.EventHubs.Processor.Tests
     ///
     public class StorageTestEnvironment: TestEnvironment
     {
-        public StorageTestEnvironment() : base("eventhubs")
-        {
-            ActiveStorageAccount = new Lazy<StorageProperties>(EnsureStorageAccount, LazyThreadSafetyMode.ExecutionAndPublication);
-        }
+        /// <summary>The singleton instance of the <see cref="StorageTestEnvironment" />, lazily created.</summary>
+        private static readonly Lazy<StorageTestEnvironment> Singleton = new Lazy<StorageTestEnvironment>(() => new StorageTestEnvironment(), LazyThreadSafetyMode.ExecutionAndPublication);
+
+        /// <summary>The active Azure storage connection for this test run, lazily created.</summary>
+        private readonly Lazy<StorageProperties> ActiveStorageAccount;
 
         /// <summary>
-        /// A shared instance of <see cref="StorageTestEnvironment"/>.
+        ///   The shared instance of the <see cref="StorageTestEnvironment"/> to be used during test runs.
         /// </summary>
-        public static StorageTestEnvironment Instance { get; } = new StorageTestEnvironment();
+        ///
+        public static StorageTestEnvironment Instance => Singleton.Value;
 
         /// <summary>The environment variable value for the storage account connection string, lazily evaluated.</summary>
         private string StorageAccountConnectionString => GetOptionalVariable("EVENT_PROCESSOR_STORAGE_CONNECTION_STRING");
 
-        /// <summary>The active Azure storage connection for this test run, lazily created.</summary>
-        private readonly Lazy<StorageProperties> ActiveStorageAccount;
-
         /// <summary>
         ///   Indicates whether or not an ephemeral storage account was created for the current test execution.
         /// </summary>
@@ -55,6 +54,15 @@ public StorageTestEnvironment() : base("eventhubs")
         ///
         public string StorageConnectionString => ActiveStorageAccount.Value.ConnectionString;
 
+        /// <summary>
+        ///   Initializes a new instance of the <see cref="StorageTestEnvironment"/> class.
+        /// </summary>
+        ///
+        public StorageTestEnvironment() : base("eventhubs")
+        {
+            ActiveStorageAccount = new Lazy<StorageProperties>(EnsureStorageAccount, LazyThreadSafetyMode.ExecutionAndPublication);
+        }
+
         /// <summary>
         ///   It tries to read the <see cref="StorageAccountConnectionString" />.
         ///   If not found, it creates a new storage account on Azure.

sdk/eventhub/Azure.Messaging.EventHubs.Processor/tests/Processor/EventProcessorClientLiveTests.cs

@@ -5,19 +5,14 @@
 using System.Collections.Concurrent;
 using System.Collections.Generic;
 using System.Linq;
-using System.Text;
 using System.Threading;
 using System.Threading.Tasks;
 using Azure.Core;
-using Azure.Identity;
 using Azure.Messaging.EventHubs.Consumer;
 using Azure.Messaging.EventHubs.Primitives;
 using Azure.Messaging.EventHubs.Processor;
-using Azure.Messaging.EventHubs.Processor.Tests;
 using Azure.Messaging.EventHubs.Producer;
-using Azure.Storage.Blobs;
 using Moq;
-using Moq.Protected;
 using NUnit.Framework;
 
 namespace Azure.Messaging.EventHubs.Tests
@@ -150,7 +145,7 @@ public async Task EventsCanBeReadByMultipleProcessorClients()
             var connectionString = EventHubsTestEnvironment.Instance.BuildConnectionStringForEventHub(scope.EventHubName);
 
             using var cancellationSource = new CancellationTokenSource();
-            cancellationSource.CancelAfter(TimeSpan.FromMinutes(6));
+            cancellationSource.CancelAfter(EventHubsTestEnvironment.Instance.TestExecutionTimeLimit);
 
             // Send a set of events.
 
@@ -217,7 +212,7 @@ public async Task ProcessorClientCreatesOwnership()
             var connectionString = EventHubsTestEnvironment.Instance.BuildConnectionStringForEventHub(scope.EventHubName);
 
             using var cancellationSource = new CancellationTokenSource();
-           cancellationSource.CancelAfter(EventHubsTestEnvironment.Instance.TestExecutionTimeLimit);
+            cancellationSource.CancelAfter(EventHubsTestEnvironment.Instance.TestExecutionTimeLimit);
 
             // Discover the partitions.
 
@@ -282,7 +277,7 @@ public async Task ProcessorClientCanStartFromAnInitialPosition()
             var connectionString = EventHubsTestEnvironment.Instance.BuildConnectionStringForEventHub(scope.EventHubName);
 
             using var cancellationSource = new CancellationTokenSource();
-           cancellationSource.CancelAfter(EventHubsTestEnvironment.Instance.TestExecutionTimeLimit);
+            cancellationSource.CancelAfter(EventHubsTestEnvironment.Instance.TestExecutionTimeLimit);
 
             // Send a set of events.
 
@@ -363,7 +358,7 @@ public async Task ProcessorClientBeginsWithTheNextEventAfterCheckpointing()
             var connectionString = EventHubsTestEnvironment.Instance.BuildConnectionStringForEventHub(scope.EventHubName);
 
             using var cancellationSource = new CancellationTokenSource();
-           cancellationSource.CancelAfter(EventHubsTestEnvironment.Instance.TestExecutionTimeLimit);
+            cancellationSource.CancelAfter(EventHubsTestEnvironment.Instance.TestExecutionTimeLimit);
 
             // Send a set of events.