Skip to content

Commit 82b9a17

Browse files
authored
feat(playwrighttesting): Adding stacktrace into error list (#47014)
* Adding stacktrace into error list * add test for null value
1 parent 8c3550e commit 82b9a17

File tree

2 files changed

+21
-5
lines changed

2 files changed

+21
-5
lines changed

sdk/playwrighttesting/Azure.Developer.MicrosoftPlaywrightTesting.TestLogger/src/Processor/DataProcessor.cs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -143,13 +143,14 @@ public static RawTestResult GetRawResultObject(TestResult? testResultSource)
143143
{
144144
if (testResultSource == null)
145145
return new RawTestResult();
146-
List <MPTError> errors = new();//[testResultSource.ErrorMessage];
146+
List <MPTError> errors = new();
147147
if (testResultSource.ErrorMessage != null)
148148
errors.Add(new MPTError() { message = testResultSource.ErrorMessage });
149+
if (testResultSource.ErrorStackTrace != null)
150+
errors.Add(new MPTError() { message = testResultSource.ErrorStackTrace });
149151
var rawTestResult = new RawTestResult
150152
{
151-
errors = JsonSerializer.Serialize(errors),
152-
stdErr = testResultSource?.ErrorStackTrace ?? string.Empty
153+
errors = JsonSerializer.Serialize(errors)
153154
};
154155
return rawTestResult;
155156
}

sdk/playwrighttesting/Azure.Developer.MicrosoftPlaywrightTesting.TestLogger/tests/Processor/DataProcessorTests.cs

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,22 @@ public void GetRawResultObject_WithNullTestResult_ReturnsRawTestResultWithEmptyE
160160
Assert.AreEqual("[]", result.stdErr);
161161
}
162162

163+
[Test]
164+
public void GetRawResultObject_WithNullErrorStackTrace_ReturnsRawTestResultWithEmptyErrorsAndStdErr()
165+
{
166+
var testResult = new TestResult(new TestCase("Test", new System.Uri("file:///test.cs"), "TestNamespace.TestClass"))
167+
{
168+
ErrorMessage = null,
169+
ErrorStackTrace = null
170+
};
171+
172+
RawTestResult result = DataProcessor.GetRawResultObject(testResult);
173+
174+
Assert.IsNotNull(result);
175+
Assert.AreEqual("[]", result.errors);
176+
Assert.AreEqual("[]", result.stdErr);
177+
}
178+
163179
[Test]
164180
public void GetRawResultObject_WithNonNullTestResult_ReturnsRawTestResultWithErrorsAndStdErr()
165181
{
@@ -172,8 +188,7 @@ public void GetRawResultObject_WithNonNullTestResult_ReturnsRawTestResultWithErr
172188
RawTestResult result = DataProcessor.GetRawResultObject(testResult);
173189

174190
Assert.IsNotNull(result);
175-
Assert.AreEqual("[{\"message\":\"An error occurred\"}]", result.errors);
176-
Assert.AreEqual("Error stack trace", result.stdErr);
191+
Assert.AreEqual("[{\"message\":\"An error occurred\"},{\"message\":\"Error stack trace\"}]", result.errors);
177192
}
178193
}
179194
}

0 commit comments

Comments
 (0)