[HMACAuthenticationPolicyTest] added new not null check for authValue (#17178)

JoshuaLai · web-flow · commit 288ff398f9ee · 2020-11-25T10:25:12.000-08:00
diff --git a/sdk/communication/Azure.Communication.Common/tests/Pipeline/HMACAuthenticationPolicyTests.cs b/sdk/communication/Azure.Communication.Common/tests/Pipeline/HMACAuthenticationPolicyTests.cs
@@ -30,8 +30,8 @@ public async Task TestHMACPolicyProcess()
 
             var expectedAuthHeader = "HMAC-SHA256 SignedHeaders=date;host;x-ms-content-sha256";
             Assert.True(headers.TryGetValue("Authorization", out var authValue));
-            authValue = (authValue == null) ? "" : authValue;
-            Assert.True(authValue.Contains(expectedAuthHeader));
+            Assert.NotNull(authValue);
+            Assert.True(authValue!.Contains(expectedAuthHeader));
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -30,8 +30,8 @@ public async Task TestHMACPolicyProcess()`
`30`	`30`
`31`	`31`	`var expectedAuthHeader = "HMAC-SHA256 SignedHeaders=date;host;x-ms-content-sha256";`
`32`	`32`	`Assert.True(headers.TryGetValue("Authorization", out var authValue));`
`33`		`- authValue = (authValue == null) ? "" : authValue;`
`34`		`- Assert.True(authValue.Contains(expectedAuthHeader));`
	`33`	`+ Assert.NotNull(authValue);`
	`34`	`+ Assert.True(authValue!.Contains(expectedAuthHeader));`
`35`	`35`	`}`
`36`	`36`	`}`
`37`	`37`	`}`