diff --git a/sdk/keyvault/keyvault-secrets/CHANGELOG.md b/sdk/keyvault/keyvault-secrets/CHANGELOG.md index 5a1cfabdfa8e..49d7488fbf81 100644 --- a/sdk/keyvault/keyvault-secrets/CHANGELOG.md +++ b/sdk/keyvault/keyvault-secrets/CHANGELOG.md @@ -4,6 +4,8 @@ - Fixed [bug 8378](https://github.com/Azure/azure-sdk-for-js/issues/8378), which caused the challenge based authentication to re-authenticate on every new request. - Fixed [bug 9005](https://github.com/Azure/azure-sdk-for-js/issues/9005), which caused parallel requests to throw if one of them needed to authenticate. +- Fixed a bug in which the `keyId` was missing on the secret properties. +- Removed the dependency of the TypeScript types for the `dom`. ## 4.0.3 (2020-05-13) diff --git a/sdk/keyvault/keyvault-secrets/review/keyvault-secrets.api.md b/sdk/keyvault/keyvault-secrets/review/keyvault-secrets.api.md index 19b6c4ae593f..2eca67abb75c 100644 --- a/sdk/keyvault/keyvault-secrets/review/keyvault-secrets.api.md +++ b/sdk/keyvault/keyvault-secrets/review/keyvault-secrets.api.md @@ -123,7 +123,7 @@ export interface SecretProperties { enabled?: boolean; readonly expiresOn?: Date; id?: string; - readonly keyId?: URL; + readonly keyId?: string; readonly managed?: boolean; name: string; readonly notBefore?: Date; diff --git a/sdk/keyvault/keyvault-secrets/src/index.ts b/sdk/keyvault/keyvault-secrets/src/index.ts index 915452b7659f..eb7576a3adb6 100644 --- a/sdk/keyvault/keyvault-secrets/src/index.ts +++ b/sdk/keyvault/keyvault-secrets/src/index.ts @@ -958,6 +958,7 @@ export class SecretClient { expiresOn: (attributes as any).expires, createdOn: (attributes as any).created, updatedOn: (attributes as any).updated, + keyId: secretBundle.kid, ...secretBundle, ...parsedId, ...attributes diff --git a/sdk/keyvault/keyvault-secrets/src/secretsModels.ts b/sdk/keyvault/keyvault-secrets/src/secretsModels.ts index 223e3a929c59..5aea0fc9b421 100644 --- a/sdk/keyvault/keyvault-secrets/src/secretsModels.ts +++ b/sdk/keyvault/keyvault-secrets/src/secretsModels.ts @@ -113,7 +113,7 @@ export interface SecretProperties { * **NOTE: This property will not be serialized. It can only be populated by * the server.** */ - readonly keyId?: URL; + readonly keyId?: string; /** * True if the secret's lifetime is managed by * key vault. If this is a secret backing a certificate, then managed will be diff --git a/sdk/keyvault/keyvault-secrets/tsconfig.json b/sdk/keyvault/keyvault-secrets/tsconfig.json index 7a5252578c4f..39e5962ffd82 100644 --- a/sdk/keyvault/keyvault-secrets/tsconfig.json +++ b/sdk/keyvault/keyvault-secrets/tsconfig.json @@ -3,7 +3,6 @@ "compilerOptions": { "declarationDir": "./types", "outDir": "./dist-esm", - "lib": ["dom"], "resolveJsonModule": true }, "exclude": ["node_modules", "../keyvault-common/node_modules", "./samples/**/*.ts"],